Repository navigation
Commit 9c90c48
fix(compat): return 400 for a non-integer v0.3 REST historyLength (#1382)
## Problem
A v0.3 REST `GetTask` with a non-integer `historyLength` returned 500,
because the `ValueError` from `int()` was not handled.
## Fix
Raise `InvalidParamsError` instead, with the same message the v1.0 REST
transport uses.
## Tests
`test_on_get_task_non_integer_history_length` and
`test_get_task_v03_non_integer_history_length` fail on main. 2325
passed.
Fixes #1381
Co-authored-by: mykytanetipa <mykytanetipa@google.com>1 parent 0d9dafb commit 9c90c48
3 files changed
Lines changed: 34 additions & 1 deletion
File tree
- src/a2a/compat/v0_3
- tests/compat/v0_3
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
250 | 251 | | |
251 | 252 | | |
252 | 253 | | |
253 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
254 | 262 | | |
255 | 263 | | |
256 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
315 | 316 | | |
316 | 317 | | |
317 | 318 | | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
318 | 332 | | |
319 | 333 | | |
320 | 334 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
202 | 213 | | |
203 | 214 | | |
204 | 215 | | |
| |||
0 commit comments