Repository navigation
Commit babc3f5
fix: reject invalid REST boolean query values (#1383)
# Description
`GET /tasks?includeArtifacts=garbage` currently returns 200 and treats
the value as `false`, silently omitting artifacts. Reject unrecognized
boolean query values with the existing `400 INVALID_ARGUMENT` response
before calling the request handler.
Preserve case-insensitive `true`/`false` parsing, the omitted-parameter
default, and last-value-wins behavior. Regression tests cover public
REST requests and parameter parsing, including malformed values,
artifact responses, and error messages that do not echo the supplied
value.
- [x] Follow the [CONTRIBUTING
guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md).
- [x] Use a Conventional Commits title.
- [x] Tests and linter pass.
- [x] No documentation change is needed.
Validation:
- `./scripts/lint.sh`
- Full suite: 2358 passed, 199 skipped, 3 xfailed, 1 xpassed (192
warnings).
- Coverage: 92.33%, above the 88% requirement.
The local full-suite and coverage runs used a temporary helper that
continuously drains the cross-version fixture servers' output to avoid
blocked pipes. The fixture assertions and timeouts were unchanged.
Co-authored-by: mykytanetipa <mykytanetipa@google.com>1 parent 9c90c48 commit babc3f5
3 files changed
Lines changed: 101 additions & 2 deletions
File tree
- src/a2a/utils
- tests
- server/routes
- utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
228 | 232 | | |
229 | 233 | | |
230 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
| 29 | + | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| |||
225 | 229 | | |
226 | 230 | | |
227 | 231 | | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
228 | 247 | | |
229 | 248 | | |
230 | 249 | | |
| |||
235 | 254 | | |
236 | 255 | | |
237 | 256 | | |
238 | | - | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
239 | 263 | | |
240 | 264 | | |
241 | 265 | | |
242 | 266 | | |
243 | 267 | | |
244 | 268 | | |
245 | 269 | | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
246 | 297 | | |
247 | 298 | | |
248 | 299 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
225 | 269 | | |
226 | 270 | | |
227 | 271 | | |
| |||
0 commit comments