|
| 1 | +from datetime import datetime, timezone |
1 | 2 | from typing import Any |
2 | 3 | from unittest.mock import AsyncMock |
3 | 4 |
|
|
20 | 21 | TaskStatusUpdateEvent, |
21 | 22 | ) |
22 | 23 | from a2a.utils.errors import InvalidAgentResponseError, InvalidParamsError |
| 24 | +from google.protobuf.timestamp_pb2 import Timestamp |
23 | 25 |
|
24 | 26 |
|
25 | 27 | class SampleUser(User): |
@@ -509,3 +511,104 @@ def test_append_artifact_to_task(): |
509 | 511 | match='append=True for nonexistent artifact_id', |
510 | 512 | ): |
511 | 513 | append_artifact_to_task(task, append_event_5) |
| 514 | + |
| 515 | + |
| 516 | +@pytest.mark.asyncio |
| 517 | +async def test_save_task_event_stamps_terminal_status_without_timestamp( |
| 518 | + task_manager: TaskManager, mock_task_store: AsyncMock |
| 519 | +) -> None: |
| 520 | + """Terminal states arriving unstamped are auto-stamped (#1331).""" |
| 521 | + initial_task = create_minimal_task() |
| 522 | + mock_task_store.get.return_value = initial_task |
| 523 | + event = TaskStatusUpdateEvent( |
| 524 | + task_id=MINIMAL_TASK_ID, |
| 525 | + context_id=MINIMAL_CONTEXT_ID, |
| 526 | + status=TaskStatus(state=TaskState.TASK_STATE_FAILED), |
| 527 | + ) |
| 528 | + |
| 529 | + await task_manager.save_task_event(event) |
| 530 | + |
| 531 | + saved_task = mock_task_store.save.call_args[0][0] |
| 532 | + assert saved_task.status.state == TaskState.TASK_STATE_FAILED |
| 533 | + assert saved_task.status.HasField('timestamp') |
| 534 | + |
| 535 | + |
| 536 | +@pytest.mark.asyncio |
| 537 | +async def test_save_task_event_preserves_provided_terminal_timestamp( |
| 538 | + task_manager: TaskManager, mock_task_store: AsyncMock |
| 539 | +) -> None: |
| 540 | + """An explicitly provided timestamp is never overwritten (#1331).""" |
| 541 | + initial_task = create_minimal_task() |
| 542 | + mock_task_store.get.return_value = initial_task |
| 543 | + provided = Timestamp() |
| 544 | + provided.FromDatetime(datetime(2026, 1, 1, tzinfo=timezone.utc)) |
| 545 | + event = TaskStatusUpdateEvent( |
| 546 | + task_id=MINIMAL_TASK_ID, |
| 547 | + context_id=MINIMAL_CONTEXT_ID, |
| 548 | + status=TaskStatus( |
| 549 | + state=TaskState.TASK_STATE_FAILED, timestamp=provided |
| 550 | + ), |
| 551 | + ) |
| 552 | + |
| 553 | + await task_manager.save_task_event(event) |
| 554 | + |
| 555 | + saved_task = mock_task_store.save.call_args[0][0] |
| 556 | + assert saved_task.status.timestamp.ToDatetime( |
| 557 | + tzinfo=timezone.utc |
| 558 | + ) == datetime(2026, 1, 1, tzinfo=timezone.utc) |
| 559 | + |
| 560 | + |
| 561 | +@pytest.mark.asyncio |
| 562 | +async def test_save_task_event_does_not_stamp_non_terminal_status( |
| 563 | + task_manager: TaskManager, mock_task_store: AsyncMock |
| 564 | +) -> None: |
| 565 | + """Non-terminal states are left alone by the backstop (#1331).""" |
| 566 | + initial_task = create_minimal_task() |
| 567 | + mock_task_store.get.return_value = initial_task |
| 568 | + event = TaskStatusUpdateEvent( |
| 569 | + task_id=MINIMAL_TASK_ID, |
| 570 | + context_id=MINIMAL_CONTEXT_ID, |
| 571 | + status=TaskStatus(state=TaskState.TASK_STATE_WORKING), |
| 572 | + ) |
| 573 | + |
| 574 | + await task_manager.save_task_event(event) |
| 575 | + |
| 576 | + saved_task = mock_task_store.save.call_args[0][0] |
| 577 | + assert saved_task.status.state == TaskState.TASK_STATE_WORKING |
| 578 | + assert not saved_task.status.HasField('timestamp') |
| 579 | + |
| 580 | + |
| 581 | +@pytest.mark.asyncio |
| 582 | +async def test_save_task_event_stamps_raw_failed_task_without_timestamp( |
| 583 | + task_manager: TaskManager, mock_task_store: AsyncMock |
| 584 | +) -> None: |
| 585 | + """The raw-Task path (direct mutation failure sites) is guarded too |
| 586 | + (#1331).""" |
| 587 | + failing_task = create_minimal_task() |
| 588 | + failing_task.status.state = TaskState.TASK_STATE_FAILED |
| 589 | + |
| 590 | + returned = await task_manager.save_task_event(failing_task) |
| 591 | + |
| 592 | + assert returned.status.state == TaskState.TASK_STATE_FAILED |
| 593 | + assert returned.status.HasField('timestamp') |
| 594 | + |
| 595 | + |
| 596 | +@pytest.mark.asyncio |
| 597 | +async def test_save_task_event_stamps_the_published_event( |
| 598 | + task_manager: TaskManager, mock_task_store: AsyncMock |
| 599 | +) -> None: |
| 600 | + """The caller's event object is stamped too, since the same instance is |
| 601 | + published to subscribers, push notifications and the event table.""" |
| 602 | + initial_task = create_minimal_task() |
| 603 | + mock_task_store.get.return_value = initial_task |
| 604 | + event = TaskStatusUpdateEvent( |
| 605 | + task_id=MINIMAL_TASK_ID, |
| 606 | + context_id=MINIMAL_CONTEXT_ID, |
| 607 | + status=TaskStatus(state=TaskState.TASK_STATE_COMPLETED), |
| 608 | + ) |
| 609 | + |
| 610 | + await task_manager.save_task_event(event) |
| 611 | + |
| 612 | + assert event.status.HasField('timestamp') |
| 613 | + saved_task = mock_task_store.save.call_args[0][0] |
| 614 | + assert saved_task.status.timestamp == event.status.timestamp |
0 commit comments