Repository navigation
Commit fad0482
fix(compat): keep timestamp and three other fields in v0.3 gRPC conversion (#1277)
## Problem
`proto_utils.py` doesn't map `TaskStatus.timestamp`,
`AgentCard.icon_url`, `OAuth2SecurityScheme.oauth2_metadata_url` or
`AgentSkill.security`, so v0.3 gRPC clients get task statuses with no
timestamp.
## Fix
Map the four fields in `ToProto` and `FromProto`, the same way
`conversions.py` does.
## Tests
`test_task_status_timestamp_roundtrip` and
`test_agent_card_optional_fields_roundtrip` in `test_proto_utils.py`.
Both fail with the source reverted.
Fixes #1276
Co-authored-by: mykytanetipa <mykytanetipa@google.com>1 parent 041c17b commit fad0482
2 files changed
Lines changed: 53 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
218 | 223 | | |
219 | 224 | | |
220 | 225 | | |
| |||
405 | 410 | | |
406 | 411 | | |
407 | 412 | | |
| 413 | + | |
408 | 414 | | |
409 | 415 | | |
410 | 416 | | |
| |||
515 | 521 | | |
516 | 522 | | |
517 | 523 | | |
| 524 | + | |
518 | 525 | | |
519 | 526 | | |
520 | 527 | | |
| |||
577 | 584 | | |
578 | 585 | | |
579 | 586 | | |
| 587 | + | |
580 | 588 | | |
581 | 589 | | |
582 | 590 | | |
| |||
689 | 697 | | |
690 | 698 | | |
691 | 699 | | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
692 | 703 | | |
693 | 704 | | |
694 | 705 | | |
| |||
876 | 887 | | |
877 | 888 | | |
878 | 889 | | |
| 890 | + | |
879 | 891 | | |
880 | 892 | | |
881 | 893 | | |
| |||
992 | 1004 | | |
993 | 1005 | | |
994 | 1006 | | |
| 1007 | + | |
| 1008 | + | |
995 | 1009 | | |
996 | 1010 | | |
997 | 1011 | | |
| |||
1086 | 1100 | | |
1087 | 1101 | | |
1088 | 1102 | | |
| 1103 | + | |
1089 | 1104 | | |
1090 | 1105 | | |
1091 | 1106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
640 | 640 | | |
641 | 641 | | |
642 | 642 | | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
643 | 680 | | |
644 | 681 | | |
645 | 682 | | |
| |||
0 commit comments