Repository navigation
refactor: remove unnecesary httpx usage in http_helpers - #1412
Open
Iwaniukooo11 wants to merge 1 commit into
Open
Iwaniukooo11 wants to merge 1 commit into
Iwaniukooo11 wants to merge 1 commit into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/transports/http_helpers.py | 92.50% | 92.13% | 🔴 -0.37% |
| Total | 93.42% | 93.41% | 🔴 -0.01% |
Generated by coverage-comment.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored timeout and headers creation in
http_helpers.pyto use plain Python types (floatanddict) instead ofhttpx.Timeoutandhttpx.Headers.Avoids coupling these helpers to
httpxtypes, which prepares for the upcominghttpx/httpx2migration (we plan to allow using both httpx and httpx2 connection, thus helpers shouldn't rely on specific version)Tests
Updated existing REST/JSON-RPC timeout assertions to expect a raw
float(was:httpx.Timeout)Added unit tests in
test_http_helpers.pyfor unwrapped timeout pass-through and case-insensitive SSE default headers.Refs #1288