Repository navigation
fix(payments-demo): 💄 show Buy now to guests instead of a sign-in link - #912
Merged
Merged
Conversation
Guests get the same Buy now button as members; it opens sign-in with returnTo=/payments-demo so they come back to the shop. The button is disabled for everyone when no payment provider is configured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CnAiFaNGAPcFw63CH3Yo77
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving Documentation
pnpm lint:fixwas run before opening this PR and changed nothing beyond this diff.Description
What?
On the payments demo shop page (
/payments-demo), guests now see the same Buy now button as signed-in members instead of a "Sign in to buy" link./login?returnTo=%2Fpayments-demo, so after signing in they land back on the shop. Core's login already sanitizesreturnTo.shop.sign_inmessage is removed.Changed files:
plugins/payments-demo/src/pages/shop-page.tsxandplugins/payments-demo/src/locales/en.json.Why?
One clear call to action for every visitor; signing in is a step of buying, not a separate link.
Verification
canary; oxlint and oxfmt are clean./login?returnTo=%2Fpayments-demo./payments-demo.Generated by Claude Code