let user choose playing midi thru fluidsynth, adplug, libadlmidi or libopnmidi

[ciros88]

dropping fmod in favor of fluidsynth

[rayman3003]

U dropped fmod, bcuz fluidsynth sounds better?

[ciros88]

Im still thinking about this, but plan is to drop fmod yeh, for multiple reasons

[rayman3003]

Im still thinking about this, but plan is to drop fmod yeh, for multiple reasons

I didn't hear midi files using fluidsynth yet, But isn't possible to still keep fmod in BZR; & let the users to choose them in plugin options, between fmod & fluidsynth and/or others?

I mean give the users more options;

Unless there are more important reasons that fmod must dropped!

[ciros88]

There is a reason you want to keep fmod?
(My) long term goal is to completely drop fmod from bzr2, which is something I've been working on for years: step by step ive dropped it from any format playback, now are left only midi (fluidsynth is very good alternative and better in everything) and network streams playback. I also started adapting the code to loose the fmod dependency (eg see commit 82e9f61, which also speedup track loading). Final step will be to completely replace the fmod audio core with another lib (eg sdl mixer)

[rayman3003]

There is a reason you want to keep fmod? (My) long term goal is to completely drop fmod from bzr2, which is something I've been working on for years: step by step ive dropped it from any format playback, now are left only midi (fluidsynth is very good alternative and better in everything) and network streams playback. I also started adapting the code to loose the fmod dependency (eg see commit 82e9f61, which also speedup track loading). Final step will be to completely replace the fmod audio core with another lib (eg sdl mixer)

Nope. I have no reason for keeping the fmod. I just though that it might better to have more options for end-users.

But now that u say that dropping fmod, have so many advantages, & also it would speeding up the streams playback, it is more reasoning to drop it.

I was just curious.

[ciros88]

basically fmod is premium-quality but closed source audio engine, and this last thing is the main reason why i'm dropping this lib. consider fmod here is used in three different ways:

1. as audio core
2. as DPS engine (eg reverb)
3. as multi format player

what i'm currently doing is to drop fmod as multi format player (point 3): i suppose you noticed thru last about 10 releases of bzr2 fmod started to play less and less formats; before it was used to play mp3, wave, flac, ogg, etc, while now i reduced it to Only midi and network streams playback: this means i've replaced it with other (and better specialized libs, eg vgmstream backed by ffmpeg). the next step is to use fluidsynth as midi playback replacement too, and then i will try to replace fmod network streams playback with vgmstream, which makes the point 3 fully done. the step after will be to replace fmod, as both audio core and dsp engine, with another lib, which will be, instead, open source: one of most promising candidates is https://github.com/libsdl-org/SDL_mixer but i still have to think about it. any fmod drop (i did until now and in future too) is always done as transparent replacement which doesn't miss any current feature or change the user experience, that makes me things harder but just trying to do my best :)

[rayman3003]

basically fmod is premium-quality but closed source audio engine, and this last thing is the main reason why i'm dropping this lib. consider fmod here is used in three different ways:

1. as audio core
2. as DPS engine (eg reverb)
3. as multi format player

what i'm currently doing is to drop fmod as multi format player (point 3): i suppose you noticed thru last about 10 releases of bzr2 fmod started to play less and less formats; before it was used to play mp3, wave, flac, ogg, etc, while now i reduced it to Only midi and network streams playback: this means i've replaced it with other (and better specialized libs, eg vgmstream backed by ffmpeg). the next step is to use fluidsynth as midi playback replacement too, and then i will try to replace fmod network streams playback with vgmstream, which makes the point 3 fully done. the step after will be to replace fmod, as both audio core and dsp engine, with another lib, which will be, instead, open source: one of most promising candidates is https://github.com/libsdl-org/SDL_mixer but i still have to think about it. any fmod drop (i did until now and in future too) is always done as transparent replacement which doesn't miss any current feature or change the user experience, that makes me things harder but just trying to do my best :)

Yeap; It is always a good choice to replace closed-source things, with open-source things. So just only for this reason, it is enough to replace it.

As a PC gamer, I see FMOD's usage in so many many video games. When u said that u used it in bzr, I though myself that they are probably related.

Open-source softwares are getting better & better in the past 4-5 years; that I grabbed most of apps from github for these last 4-5 years.

As always, u r doing a great job for making this great app.

In the past, I was a winamp user. But BZR1 & now BZR2 is my best companion for music-playback. Thank u.