feat: remember credentials by default

Author: aartoni

README.md

@@ -55,7 +55,7 @@ Or [manually](#full-options), with discovery disabled.
 | `jwksUri` | only if `discovery: false` | – | Provider JWKS URI |
 | `familyNameField` | no | `"family_name"` | Userinfo claim for last name |
 | `givenNameField` | no | `"given_name"` | Userinfo claim for first name |
-| `rememberMe` | no | `false` | Store JWT in localStorage (`true`) or cookie (`false`) |
+| `rememberMe` | no | `true` | Store JWT in localStorage (`true`) or cookie (`false`) |
 
 ### Optional routing
 

cypress/e2e/login.cy.js

@@ -21,18 +21,15 @@ describe("SSO plugin", () => {
         .should("eq", "true");
 
       // Confirm the session belongs to the OIDC-provisioned user
-      cy.getCookie("jwtToken")
-        .should("exist")
-        .then((cookie) => {
-          cy.request({
+      cy.jwtToken().then((token) =>
+        cy
+          .request({
             url: "/admin/users/me",
-            headers: {
-              Authorization: `Bearer ${decodeURIComponent(cookie.value)}`,
-            },
+            headers: { Authorization: `Bearer ${token}` },
           })
-            .its("body.data.email")
-            .should("eq", "john.doe@example.org");
-        });
+          .its("body.data.email")
+          .should("eq", "john.doe@example.org"),
+      );
     });
   });
 
@@ -43,21 +40,19 @@ describe("SSO plugin", () => {
     });
 
     it("assigns the Editor role to jane.editor@example.org via the editors group", () => {
-      cy.getCookie("jwtToken")
-        .should("exist")
-        .then((cookie) => {
-          cy.request({
+      cy.jwtToken().then((token) =>
+        cy
+          .request({
             url: "/admin/users/me",
-            headers: {
-              Authorization: `Bearer ${decodeURIComponent(cookie.value)}`,
-            },
-          }).then((res) => {
+            headers: { Authorization: `Bearer ${token}` },
+          })
+          .then((res) => {
             expect(res.body.data.email).to.eq("jane.editor@example.org");
             expect(res.body.data.roles.map((r) => r.code)).to.include(
               "strapi-editor",
             );
-          });
-        });
+          }),
+      );
     });
   });
 

cypress/support/commands.js

@@ -46,3 +46,12 @@ Cypress.Commands.add("loginAs", (username, password) => {
 
 // Convenience wrapper, logs in as the default super-admin test user.
 Cypress.Commands.add("login", () => cy.loginAs("john", "password"));
+
+Cypress.Commands.add("jwtToken", () =>
+  cy
+    .window()
+    .its("localStorage")
+    .invoke("getItem", "jwtToken")
+    .should("exist")
+    .then(JSON.parse),
+);

playground/config/plugins.ts

@@ -10,7 +10,7 @@ export default ({ env }: Core.Config.Shared.ConfigParams) => ({
   oidc: {
     enabled: true,
     config: {
-      rememberMe: false,
+      rememberMe: true,
       discovery: env.bool("OIDC_DISCOVERY", true),
       issuer: env("OIDC_ISSUER"),
       redirectUri: env("OIDC_REDIRECT_URI"),

server/src/config/index.ts

@@ -7,7 +7,7 @@ import {
 export default {
   default: {
     discovery: true,
-    rememberMe: false,
+    rememberMe: true,
     scopes: "openid profile email groups",
     familyNameField: "family_name",
     givenNameField: "given_name",