Skip to content

Commit 3685ab3

Browse files
committed
docs(compat): record snapshot and provider reentry validation [skip ci]
1 parent 64f5ef4 commit 3685ab3

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎docs/CODEX_HANDOFF.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,5 @@ Native module publication is committed in `33ef3e0a` with incremental formatting
4646
Latest validated code is now **`514a224a`**: Windows build `35218003287`, format `35218003276`, package `OptiScaler_Aurora_v1.0_20260917_compat_514a224a.7z` all succeeded. The module-publication audit records exact artifact identity, focused checks and two negative-control mutations. Next concrete work is owned immutable Init path/metadata snapshots (include the DlssNr_Proxy GetFeatureCommonInfo caller), then replacement-provider device/handle-generation shutdown and result propagation. No aurora synchronization yet; the user authorizes it after code/review/build completion, without waiting for deferred game tests. Avoid repeatedly auditing or testing already completed batches unless the new edits affect them.
4747

4848
The owned-path and metadata follow-up is now complete and pushed: **`3d2963ba`**, **`ef2276cb`**, formatting **`0cbdf8e4`**. Windows builds `35275907485` and `35276701186`, respective format checks and artifacts succeeded. Read [NGX snapshot audit](NGX_INIT_SNAPSHOTS_20260917.md) for 32 path/39 metadata checks, artifact identities and the explicit limitation that global snapshots are not yet per-device transactional configuration. Do not repeat that implementation. The next checkpoint repairs replacement-provider per-handle callback reentry; read [provider reentry audit](PROVIDER_REENTRY_20260923.md). Continue with provider-global device/generation admission and shutdown-result propagation after its build closes. No aurora merge or Release has occurred.
49+
50+
Latest validated/pushed code is **`64f5ef46`**: Windows build/package `35786223489`, format `35786223620` succeeded; 32 registry and 18 extracted Release-route checks plus affected creation/Combo checks pass. The reentry audit records artifact identity, the negative-control failure, and concrete differences between FFX/DLL/Combo shutdown that the next stage must respect. Working tree was clean after the code checkpoint. Next: replacement-provider API/device admission, old-handle generations and partial shutdown outcome propagation. Do not reimplement snapshots or per-token callback admission. `aurora` remains `e1673a16`; ordinary Compatibility-fixes pushes remain authorized, game testing deferred, no Release requested.

‎docs/PROVIDER_REENTRY_20260923.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,16 @@ D3D12 and Vulkan replacement-provider routes distinguish busy (`FAIL_NotInitiali
1717
- Affected 16 creation-failure and 44 Combo partial-release checks pass locally.
1818
- Windows full-build and package results are recorded after CI completion; none of these CPU checks validate a game/driver.
1919

20+
## Completed Windows build
21+
22+
Code checkpoint `64f5ef468a9654c83ebf75a04c33f23c00b7fee4` passed full Windows build, MSVC checks and packaging in [run 35786223489](https://github.com/abc354402600/OptiScaler-Aurora/actions/runs/35786223489); format run 35786223620 also succeeded. Job 106943575380 confirms the 32 registry, 18 Release-route, 16 creation and 44 Combo checks passed. The broader existing lifecycle CI guards also passed; unrelated installer suites were not rerun locally.
23+
24+
Artifact: `OptiScaler_Aurora_v1.0_20260922_compat_64f5ef46.7z`, id 10719838064, 234785521 bytes. GitHub API artifact digest: `sha256:f9fb12e761ab77db973bb4c7d1a9963309212908d4844f47f0183cc63767a34a` (container digest, not inner DLL hash).
25+
26+
A local negative-control build removed the active-reader admission check in a temporary copy. The regression test failed at "busy release returns without waiting or touching native handle", as intended. Production sources were not mutated by that negative control.
27+
2028
## Remaining scope
2129

2230
Provider-global Init/Shutdown still needs API/device admission, handle generation association and shutdown-result propagation. This registry fix does not prevent provider-global Shutdown racing an admitted Evaluate or an old handle reaching a reinitialized provider. Shared HUD-copy resources, Combo Create rollback when a child release fails, and application code ignoring failed release results also remain separate concerns. Do not merge this ongoing lifecycle batch to aurora until the agreed code/review/build gate is satisfied. Real-game tests remain deferred at the user's request.
31+
32+
The next implementation must preserve the distinct cleanup contracts: Nvngx_FFX::Shutdown1 currently does no teardown, while DLL providers forward native teardown; Combo forwards to two children and can partially succeed. Do not retire every live handle blindly on a global success, forward an old-generation Release into a new device context, or repeat a successful child's shutdown merely because the other child failed. D3D12 command lists can identify their device; legacy Vulkan Create lacks an explicit device and must not guess across multiple live devices. These are concrete follow-up boundaries, not completed behavior.

0 commit comments

Comments
 (0)