Skip to content

Commit deaa8f5

Browse files
committed
Update health model result to include metadata points
The name of the dictionary section is now generic and inside this there is the final value, and a new subsection with metadata points as the ecosystem, model, and version. Signed-off-by: Daniel Izquierdo Cortazar <dicortazar@gmail.com>
1 parent 93442e3 commit deaa8f5

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

‎src/grimoirelab_metrics/cli.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def grimoirelab_metrics(
205205
package_metrics["packages"][package]["repository"] = repo
206206
logging.debug(f"npm Health Score calculated for {repo}")
207207
unhealthy_score = npm_metrics_model.calculate_score(metrics["repositories"][repo]["metrics"])
208-
package_metrics["packages"][package]["npm_health_score"] = unhealthy_score
208+
package_metrics["packages"][package]["score"] = unhealthy_score
209209
else:
210210
package_metrics["packages"][package] = {"metrics": None}
211211

‎src/grimoirelab_metrics/metrics_model.py‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@
2525

2626
class npmModel:
2727

28+
# Ecosystem Name
29+
ECOSYSTEM_NAME= "npm"
30+
# Model Name
31+
MODEL_NAME = "health"
32+
# Model Version
33+
MODEL_VERSION = "0.1"
34+
2835
# We have dropped the low-impact metrics, those with a coefficient close to 0
2936
COEFFICIENTS = {
3037
'elephant_factor': -1.635941,
@@ -73,4 +80,11 @@ def calculate_score(self, metrics: Dict[str, float]) -> float:
7380
# FIXME Is this correct?
7481
probability = 0.0 if z < 0 else 1.0
7582

76-
return probability
83+
return {
84+
"value": probability,
85+
"metadata": {
86+
"ecosystem": self.ECOSYSTEM_NAME,
87+
"model": self.MODEL_NAME,
88+
"version": self.MODEL_VERSION
89+
}
90+
}

0 commit comments

Comments
 (0)