Repository navigation
Handle Debian copyright paragraphs without a License field - #5410
Open
satiricalguru wants to merge 1 commit into
Open
satiricalguru wants to merge 1 commit into
satiricalguru wants to merge 1 commit into
Conversation
Fixes aboutcode-org#2977 AI-assisted: Codex assisted with investigation, implementation and local tests. Signed-off-by: Jatin Pandey <jatinjio1212@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2977
A files paragraph without
License:reaches the nameless-license path, which still asks for the missing field's line numbers and raisesKeyError: 'license'.Skip that absent field and check Copyright/other fields for misplaced license notices. Keep the existing behavior for a present, unnamed License field. Add regressions for missing fields with and without an embedded notice.
Validation on Python 3.12:
python -m pytest -q tests/packagedcode/test_debian_copyright.py— 208 passed.developwithKeyError: 'license'.CI baseline comparison
The Python 3.14
license_validate_ignorables_2job fails the two assertions forfsl-1.1_1.RULEandfsl-1.1_2.RULE. The same assertions fail on upstream commite423b48a1fdbff26219fbeafe7e9bdef293b91fc. Both runs report 7,494 passes and two failures in this job. All 31 other reported checks passed.Upstream build · PR build
Tasks
AI assistance: Codex assisted with investigation, implementation and local tests.