Repository navigation
Fix parsing maintainers with unmatched email brackets - #5412
Open
RohitSutar1823 wants to merge 1 commit into
Open
RohitSutar1823 wants to merge 1 commit into
RohitSutar1823 wants to merge 1 commit into
Conversation
Fixes aboutcode-org#5402 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: RohitSutar1823 <252551965+RohitSutar1823@users.noreply.github.com>
RohitSutar1823
force-pushed
the
fix-parse-maintainer-name-email
branch
from
November 4, 2026 06:15
f2eb0f3 to
f6aada6
Compare
Author
|
The failing Azure check is The targeted tests pass locally:
Could this check please be rerun or treated as a baseline/infrastructure failure? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5402
This pull request fixes
parse_maintainer_name_email()so it extracts an email address only when both angle brackets are present. Previously, strings containing@were incorrectly parsed when neither bracket or only one bracket was present.Changes
src/packagedcode/utils.py.tests/packagedcode/test_utils.pycovering:Name <email>value.Tasks
venv/bin/python -m pytest tests/packagedcode/test_utils.py -q— 25 passed