Repository navigation
Fix local commoncode wheel installation on Windows - #5413
Open
Shrashti1234 wants to merge 1 commit into
Open
Shrashti1234 wants to merge 1 commit into
Shrashti1234 wants to merge 1 commit into
Conversation
Discover the commoncode wheel produced by flot instead of referring to a hardcoded 32.5.2 filename. Stop on build and install errors, and reject missing or ambiguous wheel selections so a stale artifact cannot be selected silently. Verified configure --dev installs commoncode 33.0.0 and completes successfully. Exercised the production selection block with current/future versions, paths containing spaces, no wheels, multiple wheels, and a failed installer. Assisted-by: OpenAI Codex Signed-off-by: Shrashti1234 <sharishhtia@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows source setup builds commoncode 33.0.0, then attempts to install the hardcoded
dist/commoncode-32.5.2-py3-none-any.whl. That file does not exist, so the local commoncode installation fails and setup continues with a released dependency instead.Discover the wheel in
dist, require exactly one candidate, and stop on build or installation failure. This keeps Windows setup aligned with the local build when its version changes and prevents silently selecting a stale wheel.Validation on Windows 11 / Python 3.14.2:
configure --dev: it installed the built commoncode 33.0.0 wheel and completed successfully.git -c core.whitespace=cr-at-eol diff --checkpassed; the batch file retains its existing CRLF endings.Updated AUTHORS.rst and CHANGELOG.rst. Commits include DCO sign-off.
Known base-branch CI issues: the FSL ignorable metadata and parallel-runner corrections are covered separately in #5408. Hosted checks for this PR are pending.
AI disclosure: OpenAI Codex reproduced, implemented, and validated this change and prepared the PR description at my request.