Skip to content

Commit 0d9fe1a

Browse files
committed
feat: mark unfinished pipeline runs as stale
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
1 parent 8352eb4 commit 0d9fe1a

3 files changed

Lines changed: 35 additions & 0 deletions

File tree

‎vulnerabilities/management/commands/run_scheduler.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
from vulnerabilities import models
1414
from vulnerabilities.schedules import clear_zombie_pipeline_schedules
15+
from vulnerabilities.schedules import refresh_runs
1516
from vulnerabilities.schedules import scheduled_job_exists
1617
from vulnerabilities.schedules import update_pipeline_schedule
1718

@@ -38,5 +39,6 @@ class Command(rqscheduler.Command):
3839
def handle(self, *args, **kwargs):
3940
clear_zombie_pipeline_schedules()
4041
update_pipeline_schedule()
42+
refresh_runs()
4143
init_pipeline_scheduled()
4244
super(Command, self).handle(*args, **kwargs)

‎vulnerabilities/schedules.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,3 +116,19 @@ def update_pipeline_schedule():
116116
pipeline.run_priority = run_priority
117117
pipeline.run_interval = run_interval
118118
pipeline.save()
119+
120+
121+
def mark_stale_runs():
122+
"""Mark unfinished pipeline runs as stale."""
123+
from django.db.models import Q
124+
125+
from vulnerabilities.models import PipelineRun
126+
127+
for job in PipelineRun.objects.filter(run_start_date__isnull=False).filter(
128+
Q(run_end_date__isnull=True) | Q(run_exitcode__isnull=True)
129+
):
130+
job.set_run_staled()
131+
132+
133+
def refresh_runs():
134+
mark_stale_runs()

‎vulnerabilities/tests/test_models.py‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -688,6 +688,23 @@ def test_pipelinerun_success(self):
688688
self.run1.set_run_ended(exitcode=0)
689689
self.assertEqual(self.run1.status, self.run1.Status.SUCCESS)
690690

691+
def test_pipelinerun_schedules_mark_stale_runs_unfinished_job(self):
692+
from vulnerabilities.schedules import mark_stale_runs
693+
694+
self.run1.set_run_started()
695+
self.assertEqual(self.run1.run_exitcode, None)
696+
mark_stale_runs()
697+
self.run1.refresh_from_db()
698+
self.assertEqual(self.run1.run_exitcode, 88)
699+
700+
def test_pipelinerun_schedules_mark_stale_runs_job_not_yet_started(self):
701+
from vulnerabilities.schedules import mark_stale_runs
702+
703+
self.assertEqual(self.run1.run_exitcode, None)
704+
mark_stale_runs()
705+
self.run1.refresh_from_db()
706+
self.assertEqual(self.run1.run_exitcode, None)
707+
691708

692709
class TestPipelineScheduleModel(DjangoTestCase):
693710
def setUp(self):

0 commit comments

Comments
 (0)