Remove V1 code

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/migrations/0138_remove_advisoryrelatedalias_advisory_and_more.py

@@ -0,0 +1,79 @@
+# Generated by Django 5.2.11 on 2026-10-12 08:32
+
+from django.db import migrations
+
+# V1 models/tables removed in favor of AdvisoryV2 / PackageV2.
+# Use SeparateDatabaseAndState so:
+# - state is updated with DeleteModel
+# - database uses DROP TABLE IF EXISTS (tables may already be gone on some envs)
+# Autogenerated RemoveField + AlterUniqueTogether ordering is invalid and fails
+# when fields are removed before unique_together is cleared, or when tables are
+# already missing.
+
+V1_TABLES = [
+    # Through / join tables first
+    "vulnerabilities_advisoryrelatedalias",
+    "vulnerabilities_todorelatedadvisory",
+    "vulnerabilities_affectedbypackagerelatedvulnerabilit_severities",
+    "vulnerabilities_affectedbypackagerelatedvulnerability",
+    "vulnerabilities_fixingpackagerelatedvulnerability",
+    "vulnerabilities_vulnerabilityrelatedreference",
+    "vulnerabilities_weakness_vulnerabilities",
+    "vulnerabilities_vulnerabilityreference_vulnerabilities",
+    "vulnerabilities_vulnerability_severities",
+    "vulnerabilities_vulnerability_references",
+    # Dependent models
+    "vulnerabilities_codefix",
+    "vulnerabilities_exploit",
+    "vulnerabilities_packagechangelog",
+    "vulnerabilities_vulnerabilitychangelog",
+    "vulnerabilities_alias",
+    "vulnerabilities_weakness",
+    "vulnerabilities_vulnerabilityseverity",
+    "vulnerabilities_vulnerabilityreference",
+    "vulnerabilities_advisorytodo",
+    "vulnerabilities_package",
+    "vulnerabilities_advisory",
+    "vulnerabilities_vulnerability",
+]
+
+
+def drop_v1_tables(apps, schema_editor):
+    quote = schema_editor.quote_name
+    with schema_editor.connection.cursor() as cursor:
+        for table in V1_TABLES:
+            cursor.execute(f"DROP TABLE IF EXISTS {quote(table)} CASCADE")
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("vulnerabilities", "0144_remove_advisoryv2_advisory_latest_by_avid_idx_and_more"),
+    ]
+
+    operations = [
+        migrations.SeparateDatabaseAndState(
+            database_operations=[
+                migrations.RunPython(drop_v1_tables, migrations.RunPython.noop),
+            ],
+            state_operations=[
+                migrations.DeleteModel(name="AdvisoryRelatedAlias"),
+                migrations.DeleteModel(name="ToDoRelatedAdvisory"),
+                migrations.DeleteModel(name="AdvisoryToDo"),
+                migrations.DeleteModel(name="AffectedByPackageRelatedVulnerability"),
+                migrations.DeleteModel(name="FixingPackageRelatedVulnerability"),
+                migrations.DeleteModel(name="VulnerabilityRelatedReference"),
+                migrations.DeleteModel(name="CodeFix"),
+                migrations.DeleteModel(name="Exploit"),
+                migrations.DeleteModel(name="PackageChangeLog"),
+                migrations.DeleteModel(name="VulnerabilityChangeLog"),
+                migrations.DeleteModel(name="Alias"),
+                migrations.DeleteModel(name="Weakness"),
+                migrations.DeleteModel(name="VulnerabilitySeverity"),
+                migrations.DeleteModel(name="VulnerabilityReference"),
+                migrations.DeleteModel(name="Package"),
+                migrations.DeleteModel(name="Advisory"),
+                migrations.DeleteModel(name="Vulnerability"),
+            ],
+        ),
+    ]

vulnerabilities/migrations/0145_remove_advisoryrelatedalias_advisory_and_more.py

@@ -7,20 +7,13 @@
 # See https://aboutcode.org for more information about nexB OSS projects.
 #
 
-from datetime import datetime
-
 from django.apps import apps
-from django.db import IntegrityError
 from django.db import connection
 from django.db.migrations.executor import MigrationExecutor
 from django.db.models import Count
 from django.test import TestCase
-from django.utils import timezone
-from packageurl import PackageURL
-from univers.version_range import VersionRange
 
 from vulnerabilities import severity_systems
-from vulnerabilities.utils import purl_to_dict
 
 
 class TestMigrations(TestCase):
@@ -59,83 +52,8 @@ def setUpBeforeMigration(self, apps):
         pass
 
 
-class TestCodeCommitMigration(TestMigrations):
-    """
-    Tests the migration that introduces the CodeCommit model
-    and adds new ManyToMany fields to ImpactedPackage ( affecting_commits, fixed_by_commits ).
-    """
-
-    app_name = "vulnerabilities"
-    migrate_from = "0102_alter_impactedpackage_affecting_vers_and_more"
-    migrate_to = "0103_codecommit_impactedpackage_affecting_commits_and_more"
-
-    def setUpBeforeMigration(self, apps):
-        """
-        Prepare old data before migration — this should be destroyed afterward.
-        """
-        ImpactedPackage = apps.get_model("vulnerabilities", "ImpactedPackage")
-        AdvisoryV2 = apps.get_model("vulnerabilities", "AdvisoryV2")
-
-        date = datetime.now()
-        adv = AdvisoryV2.objects.create(
-            unique_content_id="old_adv",
-            url="https://old.example.com",
-            summary="Old advisory",
-            date_collected=date,
-            advisory_id="old_adv",
-            avid="test_pipeline/old_adv",
-            datasource_id="test_pipeline",
-            # pipeline_id="test_pipeline_v2",
-        )
-        ImpactedPackage.objects.create(advisory=adv, base_purl="pkg:pypi/oldpkg")
-
-    def test_unique_constraint_on_commit_hash_and_vcs_url(self):
-        """Ensure the (commit_hash, vcs_url) uniqueness constraint works."""
-        CodeCommit = self.apps.get_model("vulnerabilities", "CodeCommit")
-
-        CodeCommit.objects.create(
-            commit_hash="abc123",
-            vcs_url="https://github.com/example/repo.git",
-            commit_rank="0",
-            commit_author="tester",
-            commit_message="message 1",
-            commit_date=datetime.now(),
-        )
-
-        with self.assertRaises(IntegrityError):
-            CodeCommit.objects.create(
-                commit_hash="abc123",
-                vcs_url="https://github.com/example/repo.git",
-            )
-
-    def test_m2m_relationships_work(self):
-        """Ensure that the new M2M relationships can store data."""
-        ImpactedPackage = self.apps.get_model("vulnerabilities", "ImpactedPackage")
-        AdvisoryV2 = self.apps.get_model("vulnerabilities", "AdvisoryV2")
-        CodeCommit = self.apps.get_model("vulnerabilities", "CodeCommit")
-
-        adv = AdvisoryV2.objects.get(
-            unique_content_id="old_adv",
-            advisory_id="old_adv",
-            avid="test_pipeline/old_adv",
-            datasource_id="test_pipeline",
-        )
-
-        impacted = ImpactedPackage.objects.get(advisory=adv, base_purl="pkg:pypi/oldpkg")
-        commit1 = CodeCommit.objects.create(
-            commit_hash="def456",
-            vcs_url="https://example.com/repo.git",
-        )
-        commit2 = CodeCommit.objects.create(
-            commit_hash="eef456",
-            vcs_url="https://example.com/repo.git",
-        )
-
-        impacted.affecting_commits.add(commit1)
-        impacted.fixed_by_commits.add(commit2)
-
-        self.assertIn(commit1, impacted.affecting_commits.all())
-        self.assertIn(commit2, impacted.fixed_by_commits.all())
+# TestCodeCommitMigration removed: CodeCommit was deleted in 0105, and migration
+# 0145 irreversibly drops V1 tables so reversing to 0102/0103 is no longer possible.
 
 
 class TestLatestAdvisoryV2Migration(TestMigrations):
@@ -523,7 +441,8 @@ def test_severity_value_cleaned(self):
 
     def test_advisory_content_id_recomputed(self):
         self.advisory1.refresh_from_db()
+        # Hash excludes url/advisory_id (compute_content_id_v2); severity value cleaned to "".
         self.assertEqual(
             self.advisory1.unique_content_id,
-            "a15d4651cb05e3513c12263a11e34bd9103f68833cac8f7ffdbbd71b9cb4cf16",
+            "885d5cc15389a644089516b7047dff3716f666a0219befe32938777ae5e686fb",
         )