Fix OVAL version ranges for non-zero epochs

Only strip a leading epoch 0 from an OVAL version. The previous string replacement removed every "0:" substring, corrupting bounds such as 10:4.14-1.1 into 14.14-1.1.

Signed-off-by: Ashutosh Panda <ashutoshpanda.india@gmail.com>

Author: Ashutosh-Panda2004

vulnerabilities/oval_parser.py

@@ -136,11 +136,15 @@ def get_version_range_from_state(self, state: OvalState) -> Optional[str]:
             version = var.text or ""
             if not version:
                 continue
+
+            # 0: is the default epoch, so remove it only when it is the
+            # leading epoch of the version. Any other "0:" is part of the
+            # version and must be kept as is.
+            if version.startswith("0:"):
+                version = version[2:]
+
             version_range = operand + version
             version_range = version_range.replace("only", "").strip()
-
-            # 0: is default epoch, remove it
-            version_range = version_range.replace("0:", "").strip()
             x_version_ranges = {
                 "<2.0.x": "2.0.x",
                 "<3.x": "3.x",

vulnerabilities/tests/test_suse_oval.py

@@ -15,6 +15,7 @@
 
 from vulnerabilities.importers.suse_oval import SuseOvalImporter
 from vulnerabilities.importers.suse_oval import filter
+from vulnerabilities.lib_oval import OvalState
 from vulnerabilities.oval_parser import OvalParser
 from vulnerabilities.tests import util_tests
 
@@ -99,6 +100,27 @@ def test_suse_oval_parse_CVE_2008_5679():
     assert def0_urls == parsed_oval.get_urls_from_definition(definition_0)
 
 
+def test_get_version_range_from_state_only_strips_leading_epoch_zero():
+    xml_doc = ET.parse(os.path.join(TEST_DATA, "org.opensuse.CVE-2008-5679.xml"))
+    translations = {"less than": "<", "equals": "=", "greater than or equal": ">="}
+    parsed_oval = OvalParser(translations, xml_doc)
+
+    cases = [
+        ("0:4.14-1.1", "<4.14-1.1"),
+        ("1:4.14-1.1", "<1:4.14-1.1"),
+        ("10:4.14-1.1", "<10:4.14-1.1"),
+        ("20:4.14-1.1", "<20:4.14-1.1"),
+        ("0:10:2.0-1", "<10:2.0-1"),
+        ("4.0:14-1", "<4.0:14-1"),
+    ]
+    for version, expected_range in cases:
+        state_element = ET.Element("rpminfo_state")
+        evr_element = ET.SubElement(state_element, "evr", {"operation": "less than"})
+        evr_element.text = version
+
+        assert parsed_oval.get_version_range_from_state(OvalState(state_element)) == expected_range
+
+
 def test_filter_suse_gz_files():
     initial_suse_gz_files = [
         "https://ftp.suse.com/pub/projects/security/oval/suse.openstack.cloud.7-affected.xml.gz",