Skip to content

Commit 733330e

Browse files
committed
fix: use X-User-Agent for Swagger API requests
- fixes: #2456 Signed-off-by: Keshav Priyadarshi <git@keshav.space>
1 parent 674cbf5 commit 733330e

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎vulnerabilities/middleware/vcio_user_agent.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ def __call__(self, request):
2424
("/api/docs/", "/api/schema/")
2525
):
2626
user_agent = request.headers.get("User-Agent", "")
27+
x_user_agent = request.headers.get("X-User-Agent", "")
2728
docs_url = request.build_absolute_uri("/api/docs/")
28-
if user_agent != settings.VCIO_USER_AGENT:
29+
if settings.VCIO_USER_AGENT not in [user_agent, x_user_agent]:
2930
return JsonResponse(
3031
{
3132
"detail": (

‎vulnerabilities/templates/drf_spectacular/swagger_ui.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
swaggerSettings.dom_id = "#swagger-ui";
3434

3535
swaggerSettings.requestInterceptor = (request) => {
36-
const userAgent = swaggerSettings.userAgent || "VCIO_API_AGENT";
37-
request.headers['User-Agent'] = userAgent;
36+
const xUserAgent = swaggerSettings.xUserAgent || "VCIO_API_AGENT";
37+
request.headers['X-User-Agent'] = xUserAgent;
3838
return request;
3939
};
4040

‎vulnerablecode/settings.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@
329329
"defaultModelsExpandDepth": 1,
330330
"displayRequestDuration": True,
331331
"docExpansion": "list",
332-
"userAgent": VCIO_USER_AGENT,
332+
"xUserAgent": VCIO_USER_AGENT,
333333
},
334334
"AUTHENTICATION_WHITELIST": [
335335
"rest_framework.authentication.TokenAuthentication",

0 commit comments

Comments
 (0)