Skip to content

Commit cb2eee0

Browse files
committed
Fix a typo in parse_vuln_ids function docs & update the test
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
1 parent 4d758e0 commit cb2eee0

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎vulnerabilities/pipelines/v2_importers/alpine_linux_importer.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def load_advisories(
260260

261261
def parse_vuln_ids(vuln_ids_string, logger=print):
262262
"""
263-
Parses a raw vulnerability ids, removes parentheses and returns the advisory_id and a list of all valid aliases.
263+
Parses a raw vulnerability ids, removes parentheses and returns the vuln_id and a list of all valid aliases.
264264
"""
265265
vuln_ids = PARENTHESES_RE.sub("", vuln_ids_string)
266266
if not vuln_ids_string:

‎vulnerabilities/tests/pipelines/v2_importers/test_alpine_linux_importer_pipeline.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def test_load_advisories_package_with_invalid_alpine_version(test_case):
9999

100100

101101
@pytest.mark.parametrize(
102-
"raw_input, expected_advisory_id, expected_aliases",
102+
"raw_input, expected_vuln_id, expected_aliases",
103103
[
104104
("CVE-2022-42332 XSA-427", "CVE-2022-42332", ["CVE-2022-42332", "XSA-427"]),
105105
(
@@ -171,7 +171,7 @@ def test_load_advisories_package_with_invalid_alpine_version(test_case):
171171
("CVE-46838", None, []), # invalid CVE
172172
],
173173
)
174-
def test_parse_vuln_ids(raw_input, expected_advisory_id, expected_aliases):
175-
advisory_id, aliases = parse_vuln_ids(raw_input)
176-
assert advisory_id == expected_advisory_id
174+
def test_parse_vuln_ids(raw_input, expected_vuln_id, expected_aliases):
175+
vuln_id, aliases = parse_vuln_ids(raw_input)
176+
assert vuln_id == expected_vuln_id
177177
assert aliases == expected_aliases

0 commit comments

Comments
 (0)