fix: remove dependency on VulnTotal utils

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

vulnerabilities/pipelines/v2_importers/redhat_importer.py

@@ -30,8 +30,8 @@
 from vulnerabilities.pipelines import VulnerableCodeBaseImporterPipelineV2
 from vulnerabilities.pipes import extractcode_utils
 from vulnerabilities.severity_systems import REDHAT_AGGREGATE
+from vulnerabilities.utils import get_item
 from vulnerabilities.utils import load_json
-from vulntotal import vulntotal_utils
 
 
 class RedHatImporterPipeline(VulnerableCodeBaseImporterPipelineV2):
@@ -135,7 +135,7 @@ def parse_advisory(self, record):
                 )
             )
 
-        impacts = get_item(advisory, "product_tree", "branches", 0, "branches", default=[])
+        impacts = get_item(advisory, "product_tree", "branches", 0, "branches") or []
         for impact in impacts:
             if impact["category"] == "product_family":
                 continue
@@ -145,7 +145,6 @@ def parse_advisory(self, record):
                     "product",
                     "product_identification_helper",
                     "purl",
-                    default=None,
                 ):
                     if not purl.startswith("pkg:rpm/"):
                         continue
@@ -188,11 +187,3 @@ def clean_download(self):
 
     def on_failure(self):
         self.clean_download()
-
-
-def get_item(entity, *attributes, default=None):
-    try:
-        result = vulntotal_utils.get_item(entity, *attributes)
-    except (KeyError, IndexError, TypeError) as e:
-        result = default
-    return result

vulnerabilities/tests/pipelines/v2_importers/test_redhat_importer_v2.py

@@ -17,6 +17,7 @@
 from vulnerabilities.models import PackageV2
 from vulnerabilities.pipelines.v2_importers.redhat_importer import RedHatImporterPipeline
 from vulnerabilities.tests import util_tests
+from vulnerabilities.tests.pipelines import TestLogger
 from vulnerabilities.utils import normalize_list
 
 TEST_DATA = Path(__file__).parent.parent.parent / "test_data" / "redhat" / "csaf_2_0"
@@ -25,10 +26,15 @@
 class TestArchLinuxImporterPipeline(TestCase):
     @patch("vulnerabilities.pipelines.v2_importers.redhat_importer.RedHatImporterPipeline.fetch")
     def test_redhat_advisories_v2(self, mock_fetch):
+        logger = TestLogger()
+
         mock_fetch.__name__ = "fetch"
         pipeline = RedHatImporterPipeline()
         pipeline.location = TEST_DATA
-        pipeline.execute()
+        pipeline.log = logger.write
+        exit_code, _ = pipeline.execute()
+
+        self.assertEqual(exit_code, 0)
         self.assertEqual(6, AdvisoryV2.objects.count())
         self.assertEqual(93, PackageV2.objects.count())
         expected_file = TEST_DATA.parent / "redhat_advisoryv2-expected.json"