[Windows] Update Service Fabric SDK, runtime, and VS functionality - #14653
Open
v-dunjadenic wants to merge 3 commits into
Open
[Windows] Update Service Fabric SDK, runtime, and VS functionality#14653v-dunjadenic wants to merge 3 commits into
v-dunjadenic wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the pinned Microsoft Service Fabric Runtime and SDK versions in the Windows image toolsets to supported releases, adjusts validation to assert the installed runtime matches the pinned version, and updates Windows software-report generation to report Service Fabric runtime and SDK separately. It also adds the Service Fabric VSIX tooling to the Windows Server 2025 + Visual Studio 2026 toolset to restore .sfproj build support in VS 2026.
Changes:
- Bump Service Fabric Runtime to
11.7.157.1and SDK to8.7.157(with updated checksums) across Windows toolsets. - Improve Windows Pester validation to assert the installed runtime version matches the toolset pin, and validate SDK presence via the SDK registry key.
- Update Windows software-report generation to report “Service Fabric Runtime” and “Service Fabric SDK” as separate entries; add Service Fabric VS tooling VSIX to the VS 2026 toolset.
File summaries
| File | Description |
|---|---|
| images/windows/toolsets/toolset-win-11-vs2026-arm64.json | Updates pinned Service Fabric runtime/SDK versions and checksums for Win11 VS2026 ARM64 toolset. |
| images/windows/toolsets/toolset-win-11-arm64.json | Updates pinned Service Fabric runtime/SDK versions and checksums for Win11 ARM64 toolset. |
| images/windows/toolsets/toolset-2025.json | Updates pinned Service Fabric runtime/SDK versions and checksums for Windows Server 2025 toolset. |
| images/windows/toolsets/toolset-2025-vs2026.json | Updates pinned Service Fabric runtime/SDK versions and checksums; adds the VS 2026 Service Fabric VSIX extension. |
| images/windows/toolsets/toolset-2022.json | Updates pinned Service Fabric runtime/SDK versions and checksums for Windows Server 2022 toolset. |
| images/windows/scripts/tests/Tools.Tests.ps1 | Strengthens Service Fabric validation: runtime version equality check + SDK registry key presence check. |
| images/windows/scripts/docs-gen/SoftwareReport.Tools.psm1 | Splits Service Fabric runtime vs SDK version discovery into separate functions/registry keys. |
| images/windows/scripts/docs-gen/Generate-SoftwareReport.ps1 | Adds “Service Fabric Runtime” to the generated software report (x64 only), alongside the SDK entry. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
116
to
119
| if (Test-IsX64) { | ||
| $tools.AddToolVersion("Service Fabric Runtime", $(Get-ServiceFabricRuntimeVersion)) | ||
| $tools.AddToolVersion("Service Fabric SDK", $(Get-ServiceFabricSDKVersion)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It will be updated during build if I understand correctly
ghost
mentioned this pull request
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an Improvement / version update.
Service Fabric runtime
10.1.2493.9590and SDK7.1.2493went out of support on June 30, 2026, so this bumps them to the currently supported runtime11.7.157.1and SDK8.7.157. Both checksums were verified by downloading the installers and hashing them.The VS 2026 image also gets the
ms-azuretools.MicrosoftVisualStudioAzureFabricVsixextension, because Visual Studio 2026 has no built-in Service Fabric component and the SDK no longer ships the VS tooling, so.sfprojbuilds have nothing to import without it. The VS 2022 toolsets are left unchanged since they still get that tooling from the built-in component.While here, the software report was reporting the runtime version under the "Service Fabric SDK" label. It now reports the runtime and the SDK separately, and the Pester test asserts the installed runtime matches the pinned version instead of only checking it is not empty.
No breaking changes are expected for users on supported cluster versions, but anyone still targeting a 10.1 or older cluster may need to pin the SDK themselves.
Related issue:
#14612
Check list