Skip to content

Optimize deployment. - #3116

Merged
khustup2 merged 4 commits into
mainfrom
ci-cd-optimize
Jan 20, 2026
Merged

Optimize deployment.#3116
khustup2 merged 4 commits into
mainfrom
ci-cd-optimize

Conversation

@khustup2

Copy link
Copy Markdown
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Copilot AI review requested due to automatic review settings January 16, 2026 21:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the deployment process by consolidating build artifact handling within the container image build job. Instead of downloading pre-built packages from a remote repository, the job now builds Debian packages directly from artifacts stored in S3.

Changes:

  • Removed dependency on repo-build job for the container image build process
  • Added AWS credentials configuration and S3 artifact download steps
  • Integrated Debian package building directly into the container image build workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/DEBIAN/"
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/"
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake"

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file includes a .so extension but the destination omits it. This creates pg_deeplake without the .so extension, which may cause PostgreSQL to fail loading the extension library. The destination should be pg_deeplake.so to match the expected library naming convention.

Suggested change
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake.so"

Copilot uses AI. Check for mistakes.
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/"
mkdir -p "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake_"${PG_VERSION}".so "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/lib/postgresql/${PG_VERSION}/lib/pg_deeplake"
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake*.sql "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a wildcard pattern with install may fail if multiple SQL files match the pattern, as install expects a single source file when the destination is a directory. Consider using a loop or copying files individually to ensure all SQL files are properly installed.

Suggested change
install -m 644 "${ARTIFACT_DIR}"/pg_deeplake*.sql "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
for sql_file in "${ARTIFACT_DIR}"/pg_deeplake*.sql; do
[ -e "${sql_file}" ] || continue
install -m 644 "${sql_file}" "${DEB_PATH}/pg-deeplake-${PG_VERSION}/usr/share/postgresql/${PG_VERSION}/extension/"
done

Copilot uses AI. Check for mistakes.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@khustup2
khustup2 merged commit 86f676e into main Jan 20, 2026
12 of 13 checks passed
@khustup2
khustup2 deleted the ci-cd-optimize branch January 20, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants