Skip to content

Make uniform add_param / add_params #49

Description

@richoux

add_param takes a std::string as an input, and add_params a std::initializer_list<char const* const>.

However it is easy to forget the final 's' or add an extra 's', and not realizing where the error comes from even after carefully reading the compilation error message. A missing/extra 's' is something easy to skip while reading the error message.

Why not having add_param and add_params taking both kind of parameters, or removing one function? The latter is certainly clearner but will brake some projects using the deleted function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions