Repository navigation
Remove dormant FitConfig fields (closes #6) - #11
Merged
Merged
Conversation
explore_rate, retrain_every and min_labels_to_start were never read by any fit or routing code. Only explore_rate was echoed into config.json. Per the maintainer decision on adrida#6, drop them to keep the OSS core minimal and paper-faithful; continual learning stays covered by update(). - remove the three fields and their __post_init__ validation (config.py) - drop the explore_rate entry from the config.json dump (api.py) - trim test_fitconfig_rejects_bad_scalars (tests/test_fit.py) - remove the three lines from the FitConfig block (docs/api.md)
adrida
approved these changes
Jun 8, 2026
adrida
left a comment
adrida
left a comment
Owner
There was a problem hiding this comment.
Reviewed against source: complete strip across all four reference sites (config fields + their __post_init__ validation, the config.json echo in api.py, the test_fitconfig_rejects_bad_scalars assertions, and the docs/api.md block). No other references remain in the tree, and update() is untouched so continual learning is unaffected. CI green across 3.9 to 3.13. Closes #6. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the decision on #6:
explore_rate,retrain_everyandmin_labels_to_startare not read by any fit or routing code (onlyexplore_ratewas echoed intoconfig.json). Removing them keeps the OSS core minimal and paper-faithful; continual learning stays covered byupdate().Following the cleanup scope from the issue:
__post_init__validation (src/tracer/config.py)explore_rateentry from theconfig.jsondump (src/tracer/api.py)test_fitconfig_rejects_bad_scalarsso it no longer asserts on the removed fields (tests/test_fit.py)FitConfigblock (docs/api.md)Verified no remaining references to the three names anywhere in the repo. Full test suite green locally on 3.12 (43 passed, 1 skipped).
Closes #6.