Skip to content

Third-party authentication - #1220

Open
imperosol wants to merge 14 commits into
taistefrom
discord-auth
Open

Third-party authentication#1220
imperosol wants to merge 14 commits into
taistefrom
discord-auth

Conversation

@imperosol

Copy link
Copy Markdown
Member

Closes #1203

@imperosol imperosol added this to Sith Oct 29, 2025
@imperosol
imperosol marked this pull request as draft October 29, 2025 12:06
@imperosol imperosol linked an issue Oct 29, 2025 that may be closed by this pull request
@imperosol imperosol removed this from Sith Oct 29, 2025
@imperosol
imperosol marked this pull request as ready for review November 3, 2025 10:17
@imperosol
imperosol force-pushed the discord-auth branch 2 times, most recently from d97c86f to 627f0ae Compare November 9, 2025 14:33
@imperosol
imperosol force-pushed the discord-auth branch 3 times, most recently from 93f2fea to f3c67fd Compare March 12, 2026 18:04

@klmp200 klmp200 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendide.
Quelques ajustements à faire et c'est parfait !

avec les données suivantes :

- l'id du client est 15
- sa clef HMAC est "beb99dd53"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu parles de clef hmac ici mais on sait pas trop de quoi tu parles. Jusqu'à présent on parlais uniquement de signature.
Moi je sais de quoi tu parles mais c'est confus.
Aussi, peut-être expliquer mieux à quoi ça sert et pourquoi on met ça

et en plus les données sont mal signées),
le 403 prime et doit être retourné par défaut.

## Signature des données

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, voilà, je pense qu'il faut remonter cette section.
Et aussi, c'est qui la clef HMAC du client d'api ? C'est assez confus

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Franchement, à part ça, la documentation est excellente

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, voilà, je pense qu'il faut remonter cette section.
Et aussi, c'est qui la clef HMAC du client d'api ? C'est assez confus

Je vais remonter ça

Franchement, à part ça, la documentation est excellente

thx

Comment thread docs/tutorial/api/account-link.md
Comment thread docs/tutorial/api/account-link.md Outdated
Comment thread docs/tutorial/api/account-link.md
Comment thread api/tests/test_third_party_auth.py
Comment thread api/views.py Outdated
Comment thread api/templates/api/third_party/auth.jinja
Comment thread core/management/commands/populate.py
Comment thread api/views.py
Comment thread api/views.py Outdated
Comment thread docs/tutorial/api/account-link.md
@imperosol
imperosol force-pushed the discord-auth branch 4 times, most recently from 6b62a57 to 4aa2675 Compare April 26, 2026 20:51
@imperosol
imperosol force-pushed the discord-auth branch 2 times, most recently from 728d031 to e25f173 Compare May 23, 2026 13:10
@imperosol
imperosol requested a review from klmp200 July 15, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authenticate sith user from third-party app

2 participants