fix(ontoserver): remove allowScaledReadWrite, scaled read-write is unsupported - #15
Merged
Merged
Conversation
edeati
force-pushed
the
fix/remove-allow-scaled-read-write
branch
from
August 13, 2026 23:22
3520b97 to
d41ba1a
Compare
edeati
changed the title
…supported Scaled deployments are read-only. Ontoserver rejects writes whenever ontoserver.deployment.scaled is set, so a scaled read-write server is not a topology that can be deployed. The chart nonetheless exposed ontoserver.deployment.allowScaledReadWrite as an opt-out from its own guard, and shipped two scaled read-write example values files that relied on it. Removes the value, its schema entry, both example files, and every public mention. The render-time guard no longer offers an escape hatch, and the README now leads the deployment-modes section with the constraint rather than burying it in a footnote. The scaledReadOnly env var collapses to a constant, since the read-write branch is now unreachable. Typed as a fix rather than a breaking change: the option was inert, so nothing that worked is being taken away. A values file still carrying allowScaledReadWrite: true alongside type: scaled and isReadOnly: false now fails to render instead of deploying a server that rejects every write. Migrate by loading content with a single-instance read-write deployment and serving it scaled and read-only.
edeati
force-pushed
the
fix/remove-allow-scaled-read-write
branch
from
August 13, 2026 23:28
d41ba1a to
5d5b97a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: scaled read-write is not supported, and there should be no public documentation of any kind of an
allowScaledReadWriteoption (ontoserver.internal.deployment.scaledReadOnlyis not public).The report is correct, and confirmed against the Ontoserver sources
ProviderBase.checkReadOnly()throws onreadonly || (scaled && scaledReadonly), andscaledReadonlydefaults totrue. So settingontoserver.deployment.scaledmakes the server reject writes regardless of anything else — a scaled read-write server is not a topology that exists.The field's own comment upstream says it exists only "to allow internal experimentation with scaled read-write deployment." It is not a public knob, and the chart should not have shipped a public option built on top of it.
What changed
Removed entirely, not just undocumented:
ontoserver.deployment.allowScaledReadWrite— the value and itsvalues.schema.jsonentryexamples/aks/scaled-rw-envoy-experimental.yamlandexamples/eks/scaled-rw-envoy-experimental.yaml— both existed only to demonstrate the flagvalidate-values.yaml. The guard now keys ontype: scaled+isReadOnly: falsealone, and the failure message no longer tells the reader how to bypass itisReadOnlydescription that cross-referenced itEmphasis added rather than just deleted, since "unsupported" was previously a footnote under an opt-in:
any / scaled / any / anyrow for read-writeontoserver.internal.deployment.scaledReadOnlynow renders as a constant"true"with a comment marking it internal. Itsfalsebranch was only reachable through the flag being removed. It still matches the upstream default.Verification
helm lintclean;helm unittest271 passtype: scaled+isReadOnly: false+allowScaledReadWrite: truenow fails to render with the new message, proving the flag is inert rather than merely undocumentedcharts/ontoserver/examples/still renders