Commit 139e819
Fix fork-PR false failures in security-scan
- continue-on-error on the SARIF upload step: GITHUB_TOKEN is forced
read-only on pull_request runs triggered from forks regardless of the
security-events: write permission declared in this workflow, so the
upload always failed on external contributions (this repo has them -
see PR #5). That failure was indistinguishable from a real Psalm
finding in the job's status. The final step already gates correctly
on steps.psalm.outcome alone, so this doesn't lose any signal.
- Drop 'develop' from the push trigger - this repo no longer has a
permanent develop branch.
Found by /code-review on PR #6.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 7b922e5 commit 139e819
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
32 | 38 | | |
33 | 39 | | |
34 | 40 | | |
35 | 41 | | |
| 42 | + | |
36 | 43 | | |
37 | 44 | | |
38 | 45 | | |
| |||
0 commit comments