Let a module opt out of the redundant stated IsA policy

Redundantly-stated IsA is an editorial policy, and not every edition has adopted
it. AMT and AU clinical content state both an AMT parent and the international
top parent it sits under, deliberately. It is not confined to the drug
hierarchy, so a semantic-tag exemption is the wrong shape for it.

The rule now fires for every module except those listed under
redundant-isa-exempt-modules in the test resources. An edition that lists
nothing - which is every edition until it chooses otherwise - gets exactly the
behaviour this rule had before the key existed. An extension whose maintainers
do want the policy keeps it, which scoping the rule to core modules would have
taken away from them.

Requires isInNamedSet on DescriptionService.

Measured over a 722,404-concept edition, rule sets common-authoring,au-authoring:

  key absent   352,500 findings, byte-identical to unmodified rules
  key = AU     346,263 findings, 6,237 dropped, 0 added

Every one of the 6,237 is on the module named in the key. The 287 findings on
inherited international core-module concepts are all still reported.

Author: dionmcm

common-authoring/relationships/redundant-is-a-relationship/RedundantIsaRelationship.drl

@@ -13,10 +13,17 @@ global java.util.List invalidContent
 global ConceptService conceptService
 global DescriptionService descriptionService
 
+// Redundantly-stated IsA is an editorial policy, and not every edition has
+// adopted it. A module whose id is listed under redundant-isa-exempt-modules in
+// the test resources is not held to it; every other module is, including the
+// international core and including extension modules whose maintainers do want
+// the rule. An edition that lists nothing - which is every edition until it
+// chooses otherwise - gets exactly the behaviour this rule had before the key
+// existed.
 rule "Redundantly stated IsA relationships."
 	dialect "mvel"
 	when
-		c : Concept(active)
+		c : Concept(active, !descriptionService.isInNamedSet("redundant-isa-exempt-modules", moduleId))
 		r1 : Relationship(active && sourceId == c.id && typeId == Constants.IS_A && characteristicTypeId == Constants.STATED_RELATIONSHIP && !axiomGCI)
 		r2 : Relationship(active && sourceId == c.id && typeId == Constants.IS_A && characteristicTypeId == Constants.STATED_RELATIONSHIP && !axiomGCI && r1.id != id)
 		statedAncestors : ArrayList(size > 0) from collect( String() from conceptService.findStatedAncestorsOfConcepts(Collections.singletonList(r1.destinationId)))

common-authoring/relationships/redundant-is-a-relationship/test-cases.json

@@ -1,4 +1,94 @@
 {
+    "givenConcepts": [
+        {
+            "id": "116680003", // Is a
+            "active": true,
+            "descriptions": [
+                {
+                    "id": "isa",
+                    "term": "Is a (attribute)"
+                }
+            ]
+        },
+        {
+            // Grandparent, international core module.
+            "id": "100001",
+            "active": true,
+            "moduleId": "900000000000207008",
+            "descriptions": [
+                {
+                    "id": "d1",
+                    "typeId": "900000000000003001", // FSN
+                    "term": "Grandparent (finding)",
+                    "acceptabilityMap": {
+                        "900000000000509007": "900000000000548007" // PREFERRED
+                    }
+                }
+            ]
+        },
+        {
+            // Parent, stated child of the grandparent.
+            "id": "100002",
+            "active": true,
+            "moduleId": "900000000000207008",
+            "descriptions": [
+                {
+                    "id": "d2",
+                    "typeId": "900000000000003001", // FSN
+                    "term": "Parent (finding)",
+                    "acceptabilityMap": {
+                        "900000000000509007": "900000000000548007" // PREFERRED
+                    }
+                }
+            ],
+            "relationships": [
+                {
+                    "id": "r0",
+                    "active": true,
+                    "typeId": "116680003", // is-a
+                    "destinationId": "100001",
+                    "characteristicTypeId": "900000000000010007" // STATED
+                }
+            ]
+        }
+    ],
     "assertConceptsPass": [],
-    "assertConceptsFail": []
+    // A concept on an extension module, stating both its parent and the
+    // grandparent that parent already sits under. The rule must still fire:
+    // redundant-isa-exempt-modules is absent from the test resources, which is
+    // the state of every edition that has not opted out, and the rule has to
+    // behave there exactly as it did before the key existed.
+    "assertConceptsFail": [
+        {
+            "id": "100003",
+            "active": true,
+            "moduleId": "32506021000036107",
+            "descriptions": [
+                {
+                    "id": "d3",
+                    "typeId": "900000000000003001", // FSN
+                    "term": "Child (finding)",
+                    "acceptabilityMap": {
+                        "900000000000509007": "900000000000548007" // PREFERRED
+                    }
+                }
+            ],
+            "relationships": [
+                {
+                    "id": "r1",
+                    "active": true,
+                    "typeId": "116680003", // is-a
+                    "destinationId": "100002",
+                    "characteristicTypeId": "900000000000010007" // STATED
+                },
+                {
+                    "id": "r2",
+                    "active": true,
+                    "typeId": "116680003", // is-a
+                    "destinationId": "100001",
+                    "characteristicTypeId": "900000000000010007" // STATED
+                }
+            ]
+        }
+    ]
 }