Compile the whitespace split pattern once - #6
Open
dionmcm wants to merge 1 commit into
Open
Conversation
CoderMChu
added a commit
that referenced
this pull request
Aug 28, 2026
Keep validation workers supplied with concepts instead of every 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch:
perf/precompile-whitespace-split· Module:snomed-drools-engineWhat
DescriptionHelpersplit description terms on the literal"\\s+"in two places.String.splitonly bypasses the regex engine for a single literal character, so"\\s+"compiled a freshPatternon every call.Change
Moved to a
static final Patternas a constant beside the three already there, removing the duplicated literal at the same time as precompiling.Impact
In reality it is a very minor gain, more for tidiness than anything.
Also considered, but not implemented
TAG_PATTERNandFULL_TAG_PATTERNboth lead with a greedy.*that backtracks across the whole term, and are hotter than this. Rewriting them aslastIndexOfarithmetic would be faster, but exact equivalence has awkward edges around terms containing newlines, and the gain was not enough to justify the risk.