AG-18413 Treat an empty-string sizeKey, colorKey or labelKey as omitted - #8054
AG-18413 Treat an empty-string sizeKey, colorKey or labelKey as omitted#8054ag-jira-agent-ci[bot] wants to merge 4 commits into
Conversation
Normalise '' to undefined on BubbleScatterSeriesProperties so the optional key columns are registered and read under the same condition, and make the quadrant preset's sizeKey branch test emptiness rather than nullishness.
|
✅ Codex review complete; no issues found View full reviewAG-18413 Treat an empty-string sizeKey, colorKey or labelKey as omittedPR: #8054 SummaryReviewed all changed mechanism and regression-test files, prioritising key processing, render suppression, no-data state, and grid visibility. Hot-path detection triggered, but no actionable regression was found. Tests could not run because the checkout lacks the FindingsP0: 0 | P1: 0 | P2: 0 | P3: 0 No issues found. VerdictAssessment: correct Empty and unmatched optional keys now consistently participate in data processing, cause the series to report no renderable data, suppress stale marker output, and receive regression coverage across scatter, bubble, colour-scale, and quadrant paths. The additional axis state distinguishes absent rows from unrenderable rows. Static inspection found no correctness or material performance issue. Required Actions: None - ready to merge |
✅ Live-test this PR in PlunkerPaste these two <script src="https://ag-grid.github.io/ag-charts/pr-8054/ag-charts-community.min.js"></script>
<script src="https://ag-grid.github.io/ag-charts/pr-8054/ag-charts-enterprise.min.js"></script>Bundles are removed automatically when the PR is closed. Updated on every push. |
ag-jira-agent-ci
Bot
added
the
aiw-applying-feedback
…hen a key matches no column An empty-string sizeKey/labelKey/colorKey was registered as a data-model column only when truthy but read back whenever non-null, so '' threw on every update pass. Register on nullishness instead, which makes '' behave exactly like any other key that names no column: one warning, no exception. A series whose key matched no datum already raised the chart's no-data overlay while still drawing markers from its remaining columns, and the axes still drew their grid behind it. Draw neither: markers are suppressed when the series has no data, and an axis hides its gridlines when every series bound to it is empty.
ag-jira-agent-ci
Bot
removed
the
aiw-applying-feedback
https://ag-grid.atlassian.net/browse/AG-18413
Fix #AG-18413