fix(client): address PR review feedback on debug logging

- Add descriptive "Event:" label to VERIFY and LEGACY log calls
- Make debugLogger accept boolean for backward compatibility via getter/setter
- Remove unnecessary (event as any).type cast on LegacyRuntimeProtocolEvent
- Add expect.assertions(1) to ensure invalid event test always asserts

Author: AlemTuzlak

sdks/typescript/packages/client/src/agent/agent.ts

@@ -51,7 +51,7 @@ export abstract class AbstractAgent {
   public messages: Message[];
   public state: State;
   public debug: ResolvedAgentDebugConfig;
-  public debugLogger: DebugLogger | undefined;
+  private _debugLogger: DebugLogger | undefined;
   public subscribers: AgentSubscriber[] = [];
   public isRunning: boolean = false;
   private middlewares: Middleware[] = [];
@@ -63,6 +63,20 @@ export abstract class AbstractAgent {
     return packageJson.version;
   }
 
+  get debugLogger(): DebugLogger | undefined {
+    return this._debugLogger;
+  }
+
+  set debugLogger(value: DebugLogger | boolean | undefined) {
+    if (typeof value === "boolean") {
+      this._debugLogger = value
+        ? createDebugLogger(resolveAgentDebugConfig(true))
+        : undefined;
+    } else {
+      this._debugLogger = value;
+    }
+  }
+
   constructor({
     agentId,
     description,
@@ -647,7 +661,7 @@ export abstract class AbstractAgent {
       (events$: Observable<LegacyRuntimeProtocolEvent>) => {
         return events$.pipe(
           map((event) => {
-            this.debugLogger?.event("LEGACY", "", event, { type: (event as any).type });
+            this.debugLogger?.event("LEGACY", "Event:", event, { type: event.type });
             return event;
           }),
         );

sdks/typescript/packages/client/src/transform/__tests__/debug.test.ts

@@ -214,6 +214,8 @@ describe("transformHttpEventStream debug logging", () => {
   });
 
   it("event invalid log: [HTTP] Event invalid: on schema parse failure", async () => {
+    expect.assertions(1);
+
     const logger = createDebugLogger({
       enabled: true,
       events: true,
@@ -225,10 +227,9 @@ describe("transformHttpEventStream debug logging", () => {
     const event$ = transformHttpEventStream(source$, logger);
 
     // Subscribe to catch the error
-    let errorCaught = false;
     event$.subscribe({
       error: () => {
-        errorCaught = true;
+        // expected
       },
     });
 
@@ -248,10 +249,6 @@ describe("transformHttpEventStream debug logging", () => {
       (call) => typeof call[0] === "string" && call[0] === "[HTTP] Event invalid:",
     );
 
-    // Either the event is invalid and logged, or the schema was lenient.
-    // If the schema rejects it, we should see the invalid log.
-    if (errorCaught) {
-      expect(invalidCalls.length).toBe(1);
-    }
+    expect(invalidCalls.length).toBe(1);
   });
 });

sdks/typescript/packages/client/src/verify/verify.ts

@@ -37,7 +37,7 @@ export const verifyEvents =
       mergeMap((event) => {
         const eventType = event.type;
 
-        log?.event("VERIFY", "", event, { type: event.type });
+        log?.event("VERIFY", "Event:", event, { type: event.type });
 
         // Check if run has errored
         if (runError) {