fix(adk-middleware): use O(1) lookup in /agents/state when use_thread_id_as_session_id is enabled - #1383
Merged
Merged
Conversation
…_id_as_session_id is enabled The /agents/state endpoint always used the O(n) _find_session_by_thread_id scan path on cache miss, even when use_thread_id_as_session_id=True. This adds a direct get_session(session_id=thread_id) lookup first when the flag is enabled, falling back to the scan only for legacy sessions. Fixes #1243 https://claude.ai/code/session_01A1RL4QvwUhWNHocM7H4xkH
…ad_id_as_session_id Use `getattr(..., False) is True` instead of direct attribute access so that MagicMock-based test fixtures (which return truthy mocks for any attribute) correctly fall through to the scan path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Python Preview PackagesVersion
Install with uvAdd the TestPyPI index to your [[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
explicit = trueThen install the packages you need: # Core SDK
uv add 'ag-ui-protocol==0.0.0.dev1774567081' --index testpypi
# Integrations (each already depends on the matching ag-ui-protocol preview)
uv add 'ag-ui-langgraph==0.0.0.dev1774567081' --index testpypi
uv add 'ag-ui-crewai==0.0.0.dev1774567081' --index testpypi
# NOTE: ag-ui-agent-spec depends on pyagentspec (git-only, not on PyPI).
# You will need to install pyagentspec separately from its git repo.
uv add 'ag-ui-agent-spec==0.0.0.dev1774567081' --index testpypi
uv add 'ag_ui_adk==0.0.0.dev1774567081' --index testpypi
uv add 'ag_ui_strands==0.0.0.dev1774567081' --index testpypiInstall with pippip install \
--index-url https://test.pypi.org/simple/ \
--extra-index-url https://pypi.org/simple/ \
ag-ui-protocol==0.0.0.dev1774567081
Commit: 829b0d9 |
@ag-ui/a2a-middleware
@ag-ui/a2ui-middleware
@ag-ui/mcp-apps-middleware
@ag-ui/middleware-starter
@ag-ui/a2a
@ag-ui/adk
@ag-ui/ag2
@ag-ui/aws-strands
@ag-ui/agno
@ag-ui/claude-agent-sdk
@ag-ui/crewai
@ag-ui/langchain
@ag-ui/langgraph
@ag-ui/langroid
@ag-ui/llamaindex
@ag-ui/mastra
@ag-ui/pydantic-ai
@ag-ui/server-starter
@ag-ui/server-starter-all-features
@ag-ui/vercel-ai-sdk
create-ag-ui-app
@ag-ui/client
@ag-ui/core
@ag-ui/encoder
@ag-ui/proto
commit: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/agents/stateendpoint always used the O(n)_find_session_by_thread_idscan on cache miss, even whenuse_thread_id_as_session_id=True. This adds a directget_session(session_id=thread_id)O(1) lookup first when the flag is enabled, falling back to the scan only for legacy sessions.getattr(..., False) is Truefor the flag check to safely handle mock-based test fixtures.Test plan
TestAgentsStateEndpointWithDirectLookup)TestAgentsStateEndpointmock tests unaffectedMore Fixes for #1243
🤖 Generated with Claude Code