fix(claude-agent-sdk): preserve preset systemPrompt when appending state/context - #2636
Open
boyuan-fh wants to merge 1 commit into
Open
fix(claude-agent-sdk): preserve preset systemPrompt when appending state/context#2636boyuan-fh wants to merge 1 commit into
boyuan-fh wants to merge 1 commit into
Conversation
…ate/context
buildOptions cast Options.systemPrompt as string and interpolated it when appending the ag-ui state/context addendum, so the SDK preset-object form ({ type: 'preset', preset, append }) flattened to "[object Object]", discarding the preset and the caller's append text. Branch on the shape: fold the addendum into a preset object's append; concatenate for the string/nullish form.
Fixes #<issue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2630
Summary
buildOptionsappended ag-ui state/context tosystemPromptby casting itas stringand interpolating it, which destroyed the SDK's preset-object form(
"[object Object]").Replace the single-path interpolation with a two-way branch:
the
appendfield sotypeandpresetsurvive.Test plan
src/adapter.buildOptions.test.tswith 6 cases:append-- both original append and addendum presentappend-- addendum becomesappend[object Object]