test(galileo): align record contract assertions

Author: namrataghadi-galileo

evaluators/contrib/galileo/src/agent_control_evaluator_galileo/records/factory.py

@@ -7,13 +7,21 @@
 
 from agent_control_models import Step
 from galileo_core.schemas.logging.session import Session
-from galileo_core.schemas.logging.span import LlmSpan, RetrieverSpan, ToolSpan
+from galileo_core.schemas.logging.span import (
+    AgentSpan,
+    ControlSpan,
+    LlmSpan,
+    RetrieverSpan,
+    ToolSpan,
+    WorkflowSpan,
+)
 from galileo_core.schemas.logging.trace import Trace
 
 from .normalization import GalileoRecordNormalizer
 
 type GalileoRecord = LlmSpan | ToolSpan | RetrieverSpan | Trace | Session
 type GalileoSpan = LlmSpan | ToolSpan | RetrieverSpan
+type GalileoCoreSpan = AgentSpan | WorkflowSpan | LlmSpan | RetrieverSpan | ToolSpan | ControlSpan
 _MISSING = object()
 _SPAN_TYPES = {"llm", "tool", "retriever"}
 _RECORD_TYPES = _SPAN_TYPES | {"trace", "session"}
@@ -45,8 +53,8 @@ def _selected_values(
     return selected_data, None
 
 
-def _span_children(children: list[GalileoRecord], *, parent_type: str) -> list[GalileoSpan]:
-    spans: list[GalileoSpan] = []
+def _span_children(children: list[GalileoRecord], *, parent_type: str) -> list[GalileoCoreSpan]:
+    spans: list[GalileoCoreSpan] = []
     for child in children:
         if not isinstance(child, (LlmSpan, ToolSpan, RetrieverSpan)):
             raise RecordFactoryError(f"Galileo {parent_type} children must be span steps.")

evaluators/contrib/galileo/tests/test_luna_evaluator.py

@@ -849,7 +849,16 @@ def handler(request: httpx.Request) -> httpx.Response:
             ).model_dump(mode="json", exclude_none=True),
             "config": {"request_timeout_seconds": 8.0},
         }
-        assert captured["body"] == expected_body
+        actual_body = captured["body"]
+        assert isinstance(actual_body, dict)
+        actual_record = actual_body["record"]
+        expected_record = expected_body["record"]
+        assert isinstance(actual_record, dict)
+        assert isinstance(expected_record, dict)
+        # Each factory call assigns a fresh created_at timestamp.
+        actual_record.pop("created_at", None)
+        expected_record.pop("created_at", None)
+        assert actual_body == expected_body
 
         # The emitted body also satisfies the exact additive Orbit #1720 shape.
         orbit_request = _Orbit1720Request.model_validate(expected_body)
@@ -859,7 +868,7 @@ def handler(request: httpx.Request) -> httpx.Response:
         assert "selected question" in json.dumps(orbit_request.record.input)
         assert "selected answer" in json.dumps(orbit_request.record.output)
         assert orbit_request.inputs.tools == orbit_request.record.tools
-        assert orbit_request.record.dataset_output == {"text": "expected"}
+        assert json.loads(orbit_request.record.dataset_output) == {"text": "expected"}
         assert orbit_request.inputs.ground_truth == {"text": "expected"}
         assert orbit_request.record.user_metadata == {"source": "runtime"}
         assert "context" not in expected_body["record"]

evaluators/contrib/galileo/tests/test_records_factory.py

@@ -880,12 +880,10 @@ class DocumentModel(BaseModel):
 def test_llm_tool_definitions_normalize_nested_pydantic_uuid_and_datetime_values() -> None:
     identifier = uuid4()
     timestamp = datetime(2025, 1, 2, tzinfo=UTC)
-    source = LlmSpan(
-        input="question",
-        tools=[{"id": identifier, "created_at": timestamp}],
+    normalized_tools = GalileoRecordNormalizer.llm_tools(
+        [{"id": identifier, "created_at": timestamp}]
     )
-    wire_json = source.model_dump(mode="json", exclude_none=True)
-    record = LlmSpan.model_validate(wire_json)
+    record = LlmSpan.model_validate({"input": "question", "tools": normalized_tools})
 
     assert isinstance(record, LlmSpan)
     assert record.tools == [
@@ -1260,6 +1258,23 @@ def test_luna_wire_hierarchy_uses_top_level_fields_not_context() -> None:
         assert rebuilt_trace.spans[0].name == "wire tool"
         assert all(span.name != "ignored span" for span in rebuilt_trace.spans)
 
+    # Galileo Core supplies empty hierarchy defaults when top-level fields are absent.
+    # Context-only hierarchy must not be treated as canonical spans or traces.
+    context_only_trace = ScorerInvokeRecord.model_validate(
+        {
+            "type": "trace",
+            "name": "context only trace",
+            "context": {
+                "children": [{"type": "tool", "name": "ignored child"}],
+                "spans": [{"type": "tool", "name": "ignored span"}],
+            },
+        }
+    )
+    rebuilt_context_only_trace = Trace.model_validate(
+        context_only_trace.model_dump(mode="json", exclude_none=True)
+    )
+    assert rebuilt_context_only_trace.spans == []
+
     context_only_session = ScorerInvokeRecord.model_validate(
         {
             "type": "session",
@@ -1268,24 +1283,8 @@ def test_luna_wire_hierarchy_uses_top_level_fields_not_context() -> None:
         }
     )
     context_only_json = context_only_session.model_dump(mode="json", exclude_none=True)
-    with pytest.raises(ValidationError) as missing_spans:
-        Trace.model_validate(
-            ScorerInvokeRecord.model_validate(
-                {
-                    "type": "trace",
-                    "name": "context only trace",
-                    "context": {
-                        "children": [{"type": "tool", "name": "ignored child"}],
-                        "spans": [{"type": "tool", "name": "ignored span"}],
-                    },
-                }
-            ).model_dump(mode="json", exclude_none=True)
-        )
-    assert any(error["loc"] == ("spans",) for error in missing_spans.value.errors())
-
-    with pytest.raises(ValidationError) as missing_traces:
-        Session.model_validate(context_only_json)
-    assert any(error["loc"] == ("traces",) for error in missing_traces.value.errors())
+    rebuilt_context_only_session = Session.model_validate(context_only_json)
+    assert rebuilt_context_only_session.traces == []
 
 
 def test_luna_wire_round_trip_preserves_all_trace_span_types_and_nested_tool_span() -> None:
@@ -1337,8 +1336,6 @@ def test_luna_wire_round_trip_preserves_all_trace_span_types_and_nested_tool_spa
 @pytest.mark.parametrize(
     ("payload", "core_model"),
     [
-        ({"type": "trace", "name": "trace", "input": "question"}, Trace),
-        ({"type": "session", "name": "session"}, Session),
         (
             {
                 "type": "session",
@@ -1357,7 +1354,7 @@ def test_luna_wire_round_trip_preserves_all_trace_span_types_and_nested_tool_spa
         ),
     ],
 )
-def test_luna_wire_records_reject_missing_or_invalid_hierarchy(
+def test_luna_wire_records_reject_invalid_hierarchy(
     payload: dict[str, object],
     core_model: type[BaseModel],
 ) -> None: