Repository navigation
fix(server): repair Orbit binding ID auth and preserve legacy upstreams [SAO-17527] - #273
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
josjeon
force-pushed
the
fix/sao-17527-binding-id-auth-context
branch
from
September 30, 2026 16:08
4c7725d to
39138dd
Compare
josjeon
enabled auto-merge (squash)
September 30, 2026 19:32
wrisa
reviewed
Oct 1, 2026
wrisa
approved these changes
Oct 1, 2026
namrataghadi-galileo
approved these changes
Oct 1, 2026
josjeon
disabled auto-merge
October 1, 2026 16:06
Resolve caller identity before the namespace-scoped binding lookup, then authorize against the stored target. Preserve 401 responses and mask missing or target-denied bindings as 404. Add provider and endpoint regression coverage and refresh generated TypeScript route descriptions.
josjeon
force-pushed
the
fix/sao-17527-binding-id-auth-context
branch
from
October 1, 2026 17:37
2edb64d to
5fb016b
Compare
josjeon
enabled auto-merge (squash)
October 1, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SAO-17527 reports 10/10 failures for
DELETE /api/v1/control-bindings/{binding_id}in demo-v2-poc. The ID route sentcontrol_bindings.writewithout target context. Orbit rejected that request with 400, which Agent Control surfaced as 502. GET and PATCH use the same by-ID authorization pattern by source inspection; their failure was not reproduced live for this ticket.Change
control_bindings.readorcontrol_bindings.writewith its stored target. The handler reads or mutates the row in the authorized namespace again.AGENT_CONTROL_AUTH_UPSTREAM_IDENTITY_URLis optional; compatible custom upstreams can set it to opt into stored-target authorization. Those deployments do not need a new setting to keep their prior behavior.Validation
mainata0d2660(#277).git range-diffconfirms all four PR patches are unchanged, and localmake prepushpassed after the rebase.5fb016b.Rollout and remaining risk
POST /internal/auth/resolve_tenant_contextand that its management authorization URL matches the known path. Target-aware ID calls add one identity request before the stored-target authorization request.