You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3cca0f5
Browse filesBrowse the repository at this point in the historyBrowse files
fix(e2b): address review feedback on volume mounts
- Keep E2bSandboxState forward compatible with
@JsonIgnoreProperties(ignoreUnknown = true) so states written with
mounts load on older builds instead of falling back to fresh create
- Fix tarExcludeArgsForAbsolutePaths for workspaceRoot "/" and
collapse duplicate slashes, matching E2bVolumeMount normalization
- Keep E2bCloudBucketMountStrategy as @deprecated for one transition
release instead of removing the public interface outright
- Centralize distinct-mount-path validation in E2bVolumeMount and
enforce it in E2bSandboxState.setVolumeMounts as well
- Add unit tests for the volume-critical branches (persist no-op,
empty hydrate, destroy skip), "/" excludes, state validation and
unknown-field serde so CI catches regressions
- Fix misplaced javadoc on requireAbsoluteWorkspaceRoot and enforce
the absolute-root check in resume() too
- Require E2B_VOLUME_NAME for live tests instead of a hardcoded
default volume
- Document read-write/multi-mount/no-locking volume semantics
Refs: #3155
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bSandboxClient.java
+10-3Lines changed: 10 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -88,6 +88,7 @@ public Sandbox resume(SandboxState state) {
88
88
thrownewIllegalArgumentException(
89
89
"Expected E2bSandboxState but got: " + state.getClass().getName());
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bSandboxClientOptions.java
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bSandboxState.java
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bVolumeMount.java
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/test/java/io/agentscope/extensions/sandbox/e2b/E2bVolumeMountLiveTest.java
+7-3Lines changed: 7 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -41,8 +41,8 @@
41
41
importorg.slf4j.LoggerFactory;
42
42
43
43
// Live E2B volume tests: run only when E2B_API_KEY is set in the environment.
44
-
// Volume name comes from E2B_VOLUME_NAME (defaults to probe-ws-test1, so set it when your
45
-
// account uses a different volume).
44
+
// E2B_VOLUME_NAME must name an existing volume on the account (no default:
45
+
// the platform answers an unknown name with an opaque 400).
46
46
// Each test kills every sandbox it creates, even on failure.
Copy file name to clipboardExpand all lines: agentscope-extensions/agentscope-extensions-sandbox/agentscope-extensions-sandbox-e2b/src/test/java/io/agentscope/extensions/sandbox/e2b/E2bVolumeMountTest.java
0 commit comments