feat: exercise every A2A RPC in the echo agent example - #8
Merged
Merged
Conversation
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
arpad-csepi
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the echo agent to cover the A2A calls that were compiled but never
exercised at runtime, and fixes a server crash found while doing so.
Changes
SendMessage,SendStreamingMessage+GetTask,SubscribeToTask+CancelTask,GetExtendedAgentCard— selectable with--demo message,stream,cancel,card.stream: <text>runs a task emitting one artifact per word,slow: <seconds>runs a cancellable long task, anything else replies with a plain message.
domain events.
Fix: protobuf runtime pin
proto-google-common-protos2.70.0 is generated against protobuf 4.33.2 whilethe runtime was pinned to 4.33.1. Building an
AgentCardproto loadscom.google.api.AnnotationsProto, whose version check fails with anExceptionInInitializerError;SlimA2AHandlercatches onlyA2AError, so thatErrorescaped and killed the server process. This is theGetExtendedAgentCard"hang" the example previously warned about — clients wereseeing
DEADLINE_EXCEEDEDagainst a dead server. Raising the pin to 4.33.2fixes it, and the call now returns the card.
Verification
All four demos pass against a local SLIM 2.0.0 gateway, across three
consecutive client runs on one long-lived server. CI has no gateway, so it only
compiles these examples — the runtime results are from local runs.
Follow-ups (not in this PR)
A2AEventStreambelongs inslim-a2a: every caller ofsendStreamingMessage/subscribeToTaskneeds it, since those return aResponseStreamReaderof protobuf bytes.SlimA2AHandlershould containRuntimeException/Errorfrom a handlerrather than letting it take down the agent.
🤖 Generated with Claude Code