Conversation
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
There was a problem hiding this comment.
I have a couple issues with this PR. The original docs pre-2.0.0 did include the docs like this but there are a few issues with that so I removed it and inlined the docs.
First this change makes the docs track SDK documentation from slim-bindings main. This results in unreleased doc changes going out.
Related to this structure of the docs is defined in this repo so if we want to change that we have an issue because we can't merge changes to main docs in slim-bindings to move to the new structure without breaking the existing docs.
I would ask what we're gaining from this change, we're introducing a weird dependency cycle, today the docs are monorepoed here but they are versioned/released separately.
If we want to do this "split" properly then I think we need to use either split the docs out of SLIM into a separate slim-docs repo to make the separate versioning obvious.
OR
We should use GitHub actions to have slim-bindings publish it's pages into the slim/gh-pages branch itself.
Description
Fixes #1892
Together with slim-bindings PR #77, this PR moves the SDK docs to the slim-bindings repo and reuses the content from there when building the documentation.
Type of Change
Checklist