Pin the platform identity charts and give the Orchestrator its identity - #110
Open
vitramir wants to merge 5 commits into
Open
Pin the platform identity charts and give the Orchestrator its identity#110vitramir wants to merge 5 commits into
vitramir wants to merge 5 commits into
Conversation
It calls Notifications and Runners as the platform rather than naming one of the agent instances it reconciles, which is what it used to do to satisfy checks written for those instances. Without this value the service has no identity to be and refuses to start.
gateway 0.26.0, notifications 0.5.0, runners 0.8.0, agents-orchestrator 0.19.0, k8s-runner 0.11.0, groups 0.2.0. groups also closes a drift of its own: 0.1.1 was published while this pinned 0.1.0.
vitramir
changed the title
It belongs in the agents-orchestrator chart, not here. The value is internal plumbing the platform provisions itself with -- a constant, by that chart's own description -- so the service defaults it and runs out of the box rather than every install having to supply it.
0.19.0 required PLATFORM_IDENTITY_ID without defaulting it, so the chart could not run standalone and an internal constant looked like installation config.
This dependency is vendored from the copy in this repo rather than pulled from the registry, so the published chart never reaches the umbrella -- this is what ships, and its appVersion picks the image. At 0.1.2 it refuses the Orchestrator, which now calls Groups as the platform rather than as the agent whose groups it reads. Shipping that orchestrator against this groups would fail group sync outright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits.
PLATFORM_IDENTITY_IDon agents-orchestrator, from the sameplatformAdminIdentityIdanchor Identity already uses. The Orchestrator now calls Notifications, Agents, Groups and Runners as the platform rather than naming one of the agent instances it reconciles — and refuses to start without this value, so it must land with the version bump below rather than after it.Six chart pins: gateway 0.26.0, notifications 0.5.0, runners 0.8.0, agents-orchestrator 0.19.0, k8s-runner 0.11.0, groups 0.2.0.
Together these carry: the removal of all identity impersonation across the Orchestrator, the cluster-wide notification rooms, runner-reported workload state, and a gateway that compiles again — it had not built since the sandbox-layout RPCs were added, with the dev file watcher quietly serving the last good binary.
groups 0.2.0 also closes a drift of its own: 0.1.1 was published while this pinned 0.1.0.