Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## [Unreleased]

## [0.7.3] - 2025-09-12

- Fix hostname coercion

## [0.7.1] - 2025-09-07

- Add password rule
Expand Down
2 changes: 1 addition & 1 deletion lib/mini_defender/rules/hostname.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def coerce(value)
value.to_s
.downcase
.strip
.gsub(/.\z/, '')
.gsub(/\.\z/, '')
end

def passes?(attribute, value, validator)
Expand Down
2 changes: 1 addition & 1 deletion lib/mini_defender/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module MiniDefender
VERSION = "0.7.2"
VERSION = "0.7.3"
end
11 changes: 8 additions & 3 deletions test/rules/hostname_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require 'test_helper'

class PasswordTest < Minitest::Test
class HostnameTest < Minitest::Test
def setup
@rule = MiniDefender::Rules::Hostname.new
end
Expand All @@ -15,8 +15,13 @@ def test_pass_for_trailing_dot
assert(@rule.passes?('hostname', 'www.example.com.', nil))
end

def test_must_remove_trailing_dot
assert(@rule.coerce('www.example.com'))
def test_must_coerce_valid_host
host = 'www.example.com'
assert_equal(@rule.coerce(host), host)
end

def test_must_coerce_remove_trailing_dot
assert_equal(@rule.coerce('www.example.com.'), 'www.example.com')
end

def test_fail_for_non_ascii
Expand Down