Harden instrumentation and remove dead code - #80
Open
aidenybai wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7388b4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
aidenybai
marked this pull request as ready for review
July 24, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fiberRootstracking while removing dead commit/root bookkeepingbippyruntime changesRoot causes addressed
Several independent mutable values were being treated as though they had one global owner:
getRDTHookreturned the hook captured before an activation callback could synchronously replace itThe website also carried generalized UI variants and eight visualization modes although the app rendered only one fixed configuration.
Item 8: dispatcher handling
The dispatcher clearing is necessary while
describeNativeComponentFrameinvokes a component outside a React render to synthesize its stack frame. Leaving a live dispatcher installed can make hook calls read or mutate renderer state during that probe.The previous implementation was unsafe for multiple renderers: it read one dispatcher from either renderer collection, wrote only the internal collection, and restored that one value into every renderer. Renderers may also expose the ref as either
Horcurrent. The new implementation deduplicates all renderer refs, snapshots each ref independently, clears each during the probe, and restores its exact prior value. Removing the mechanism entirely would require removing this fallback stack-frame synthesis.Intentional behavior retained
_fiberRootsremains a strong set. It is required for root traversal and host-instance fallback behavior and was explicitly treated as intentional.Validation
vp install --frozen-lockfilevp check— 0 errors; 24 existing warningsvp test— 569 passed, 2 skippednr test:e2e— 381 passed, 3 skipped across Vite, Next.js, and TanStacknr buildvp run @bippy/website#buildnr publint— passed with the existing non-breakingpkg.browsersuggestion