fix(figure-composer): harden delegated figure workflow - #1952
Draft
wen2zhou wants to merge 2 commits into
Draft
Conversation
wen2zhou
force-pushed
the
fix/figure-composer-orchestration
branch
from
August 31, 2026 10:06
7502662 to
e290c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bundled Figure Composer skill left important orchestration rules implicit. A run could treat the latest completed child as the whole result, accept missing structured output, compose in the main agent, skip formal review, or return a stale composite after a retry. The existing tests did not launch the packaged Electron application, so those failures were not covered end to end.
Proposed change
Scope and non-goals
This PR changes only the Figure Composer skill, its kernel helpers/tests, and the Electron E2E fixture/gate. It does not change OpenCode behavior, generic delegation authentication, or generic ACP process shutdown; those application concerns are isolated in separate PRs.
Acceptance criteria and validation
npx vitest run resources/skills/figure-composer/kernel.test.ts— 4/4 passed.e2e/figure-composer-live.spec.tswith the locally configured Codex subscription provider andgpt-5.6-luna— passed in 40.0 minutes.acp connection closedoccurred.npm run typecheck— passed.npm run lint— passed.npm test— 1291 files / 21706 tests passed; 16 files / 238 tests skipped.Uncovered risk: the opt-in live gate was exercised on macOS with Codex subscription authentication. Other operating systems and providers remain covered by the normal unit/integration suite rather than this local live run.
Review focus