Make using :via with :default work and take precedence over :pred only - #25
Open
martin-senft-flexiana wants to merge 2 commits into
Open
Make using :via with :default work and take precedence over :pred only#25martin-senft-flexiana wants to merge 2 commits into
martin-senft-flexiana wants to merge 2 commits into
Conversation
Owner
|
I see. That would be useful for overly complex predicates were you have a defined spec on a keyword. Than it's easier to dispatch on Can you pleas add a section to the README explaining and motivating this with your example? Tanks! |
Author
|
Thank you for your quick reaction. I have added documentation sections for spec-specific default phrasers and phraser matching priorities. |
This makes having a single phraser cover all possible failure cases for one spec
possible with `(defphraser :default {:via [::some-spec]})`.
martin-senft-flexiana
force-pushed
the
allow_via_without_pred
branch
from
September 7, 2018 06:32
ac1177b to
da8ceed
Compare
Author
|
@alexanderkiel Can you please share you thoughts on the current state of this PR? I would like to know if it still makes sense to you and if it is good enough to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes having a single phraser cover all possible failure cases for one spec
possible with
(defphraser :default {:via [::some-spec]}).