Repository navigation
Conversation
AnthropicClient.completion()/acompletion() indexed response.content[0] directly, assuming it was always the text block. When extended thinking is enabled, Anthropic returns a ThinkingBlock first, which has no .text attribute and crashes the call. Extract the first block with type=="text" instead, and raise a clear error if none is present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnthropicClient.completion()/acompletion()indexedresponse.content[0].textdirectly, assuming the first content block is always text.ThinkingBlockfirst, which has no.textattribute, so the call crashes withAttributeError: 'ThinkingBlock' object has no attribute 'text'. Hit this in a live run againstclaude-sonnet-5._extract_text()helper that scansresponse.contentfor the firsttype == "text"block and raises a clearValueErrorif none is present (fail-loud rather than a silent empty-string fallback), and uses it in bothcompletion()andacompletion().Test plan
tests/clients/test_anthropic.py(none existed before), including a regression test reproducing the exact crash shape (leadingThinkingBlock+ trailing text block, for both sync and async).uv run ruff check/uv run ruff format --checkclean.uv run pytestsuite passes: 336 passed, 9 skipped.🤖 Generated with Claude Code