Repository navigation
Parse XML tool-use repl blocks in find_code_blocks - #189
Open
MohammadHijjawi97 wants to merge 1 commit into
Open
MohammadHijjawi97 wants to merge 1 commit into
MohammadHijjawi97 wants to merge 1 commit into
Conversation
Claude models often emit native XML tool-use syntax (<invoke name="repl"><parameter name="code">...</parameter></invoke>) instead of ```repl``` fences, so none of their code was executed. Fall back to parsing those blocks when no fenced block is present. Fixes alexzhang13#179
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179
Claude models often emit their native XML tool-use syntax instead of
replfences:find_code_blocks()only matched fences, so none of that code was executed and the model went on to hallucinate the outputs.Changes:
find_code_blocks()now falls back to parsing<invoke name="repl"><parameter name="code">...</parameter></invoke>blocks when noreplfence is present, which is the fix proposed in the issue. Fenced parsing and ordering are unchanged, and fences take precedence when both appear.tests/test_parsing.pyfor single and multiple XML blocks, ignoring non-replinvokes, and fence precedence.Tests:
pytest tests/test_parsing.py tests/test_imports.py(55 passed, 3 skipped);ruff check/ruff format --checkclean. The XML tests fail without the change.Note: #175 adds a None guard in the same function, so whichever lands second may need a trivial rebase.