Repository navigation
fix: handle None root_model in lm_handler - #5
Merged
alexzhang13 merged 1 commit intoJan 4, 2026
Merged
Conversation
When users call llm_query(prompt) without specifying a model, request.model is None. The handler correctly uses the default client but was recording None as root_model, causing TypeError in verbose printer. Now falls back to client.model_name when request.model is None.
jakemannix
added a commit
to jakemannix/rlm
that referenced
this pull request
Jun 10, 2026
…tive, scale+persistence) - baselines on identical inputs: no-memory floor, in-context ceiling, embed+kNN retrieval@1, vs the persisted memory (item 3 — 'is memory pulling its weight'). - generative exact-match via generate_greedy (item 4) + neutral-KL no-regression at scale. - scale+persistence (item 5): ingest the held-out bank one fact at a time, save->reload between each (deployment regime), query ALL facts so far at checkpoints, report worst-case frac_top5 + min_lift as the store grows to O(10^2-10^3). All on held-out (eval-split) real entities. Wired into real_text_sweep.sh (verbatim + paraphrase). Milestone-3 build complete (#1-alexzhang13#5). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jakemannix
added a commit
to jakemannix/rlm
that referenced
this pull request
Jun 10, 2026
…streamed-session dynamics not key geometry base/whiten/pressure_whiten A3 curves; whitening fixed key geometry (cos 0.10) but multifact-session recall caps at ~8 clean. Milestone-3 alexzhang13#5 (real save/reload scale) is the deployment-faithful capacity test, now running. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
root_modelllm_query(prompt)without specifying a model,request.modelisNoneNoneasroot_modelclient.model_namewhenrequest.modelisNoneError