Repository navigation
fix: resolve type mismatch regarding usage summary - #55
Merged
Merged
Conversation
Update BaseLM.get_last_usage type hint to return ModelUsageSummary, reflecting actual client implementations. Wrap atomic usage stats in UsageSummary within LMHandler to satisfy RLMChatCompletion type expectations and ensure consistent serialization structure.
Owner
|
Nice catch, thank you! |
alexzhang13
approved these changes
Jan 19, 2026
ShaneIsley
pushed a commit
to ShaneIsley/rlm
that referenced
this pull request
Jan 29, 2026
Merged 4 commits from upstream (alexzhang13/rlm): - fix: ensure docker env uses shared workspace dir (alexzhang13#48) - fix: resolve type mismatch in usage summary propagation (alexzhang13#55) - feat: add Daytona sandbox support (alexzhang13#36) - fix: propagate depth and persistent parameters in DaytonaREPL (alexzhang13#71) Resolved conflicts in rlm/core/types.py and rlm/environments/__init__.py to integrate Daytona with our registry-based environment system. https://claude.ai/code/session_01VU6KvWSCkKinCMxQDXdNxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a type mismatch in the LM handler. Raw
ModelUsageSummarywas directly passed toRLMChatCompletion, but it actually expects theUsageSummarywrapper.I also updated the type hint in
BaseLMto match what the clients are actually returning.