fix(dump): isolate IBCMD data directory - #35
Conversation
- route IBCMD dump calls through workPath/ibcmd-data\n- document and test the isolated standalone-server state
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughIBCMD DSL получил опциональный ChangesИзоляция данных IBCMD
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant DumpCommand
participant build_ibcmd_dsl
participant IbcmdDsl
participant ibcmd
DumpCommand->>build_ibcmd_dsl: Запрашивает DSL для dump
build_ibcmd_dsl->>build_ibcmd_dsl: Создаёт workPath/ibcmd-data
build_ibcmd_dsl->>IbcmdDsl: Передаёт data_path
IbcmdDsl->>ibcmd: Запускает команду с --data
ibcmd-->>DumpCommand: Возвращает результат dump
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
- document workPath/ibcmd-data runtime ownership - cover IBCMD data path argument order and dump modes
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/cli_dump.rs (1)
164-172: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winПроверьте также создание каталога.
Сейчас helper проверяет только текст команды; если
create_dir_allудалить, mock-тесты продолжат проходить. Добавьтеassert!(work_path.join("ibcmd-data").is_dir()).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/cli_dump.rs` around lines 164 - 172, Update assert_ibcmd_data_path to also assert that work_path.join("ibcmd-data") exists as a directory, while preserving the existing command-text assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/cli_dump.rs`:
- Around line 164-172: Обновите assert_ibcmd_data_path, чтобы сообщение об
ошибке не выводило полный calls с чувствительными аргументами --password и
--database-password. Оставьте в диагностике только ожидаемый фрагмент либо
предварительно редактируйте секретные значения.
---
Nitpick comments:
In `@tests/cli_dump.rs`:
- Around line 164-172: Update assert_ibcmd_data_path to also assert that
work_path.join("ibcmd-data") exists as a directory, while preserving the
existing command-text assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6221f56e-671e-4484-bfd9-b68070e8b842
📒 Files selected for processing (7)
SKILL/references/config-and-backends.mdSKILL/references/troubleshooting.mddocs/CAPABILITIES.mdspec/decisions/0002-izolirovat-runtime-state-po-source-set-pod-workpath.mdsrc/platform/ibcmd.rssrc/use_cases/dump_config/helpers.rstests/cli_dump.rs
@ Conflicts: @ tests/cli_dump.rs
- report only the expected data path fragment
2 participants
Closes #11
Summary by CodeRabbit
workPath/ibcmd-data, который передаётся в вызовыibcmdчерез аргумент--data.format(DESIGNER/EDT) иbuilder(DESIGNER/IBCMD), включая ограничения на тип инфобазы.workPathи безопасному удалениюworkPath/ibcmd-data/.calls.log: подтверждается передача--data <work_path>/ibcmd-dataдля сценариев full/incremental/partial и серверного подключения.