ResoDrive 0.3.3

Author: alphasixtyfive

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.3.3] - 2026-08-28
+
+- Do not abort an upgrade when optional graceful-shutdown preparation fails.
+- Wait for path-matched installed processes to exit before replacing files.
+- Treat an already-stopped application as a successful installer no-op.
+- Include the MSI log path in failed application-update diagnostics.
+
 ## [0.3.2] - 2026-08-28
 
 - Keep the per-user startup task registered when Windows normalizes its saved
@@ -28,6 +35,7 @@ First public preview of the cleaned ResoDrive codebase.
 - Install through a small setup bundle that downloads the .NET Desktop Runtime
   only when it is missing.
 
+[0.3.3]: https://github.com/alphasixtyfive/resodrive/releases/tag/v0.3.3
 [0.3.2]: https://github.com/alphasixtyfive/resodrive/releases/tag/v0.3.2
 [0.3.1]: https://github.com/alphasixtyfive/resodrive/releases/tag/v0.3.1
 [0.3.0]: https://github.com/alphasixtyfive/resodrive/releases/tag/v0.3.0

Directory.Build.props

@@ -9,7 +9,7 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <Deterministic>true</Deterministic>
     <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
-    <VersionPrefix>0.3.2</VersionPrefix>
+    <VersionPrefix>0.3.3</VersionPrefix>
     <ProductDisplayName>ResoDrive</ProductDisplayName>
     <ExecutableBaseName>resodrive</ExecutableBaseName>
     <ProductDescription>Mount Nextcloud, other WebDAV storage, and SFTP servers as drives in Windows</ProductDescription>

RELEASE_NOTES.md

@@ -1,10 +1,12 @@
-ResoDrive 0.3.2 fixes Start with Windows registration on systems where Windows
-Task Scheduler normalizes the saved user identity and default privilege fields.
-ResoDrive now recognizes the normalized task as its own instead of removing it
-during post-registration verification.
+ResoDrive 0.3.3 fixes application updates that could stop with Windows Installer
+code 1603 when the optional graceful-shutdown preparation returned an error.
+Preparation is now best-effort; the installer always continues to a hidden,
+path-scoped fallback that stops only the installed ResoDrive processes and waits
+for them to exit before replacing files. An already-stopped application is now
+handled as a successful no-op instead of another installer error.
 
-Installer upgrades no longer open PowerShell windows while stopping the running
-application.
+Failed updates now include the exact installer-log path in their diagnostic
+message.
 
 The normal download is `ResoDrive-Setup.exe`. Existing settings, credentials,
 mounts, and sync jobs are preserved during the upgrade.

installer/Package.wxs

@@ -92,13 +92,13 @@
       FileRef="ResoDriveExecutableFile"
       ExeCommand="--prepare-update"
       Execute="immediate"
-      Return="check"
+      Return="ignore"
       Impersonate="yes"
     />
     <CustomAction
       Id="StopResoDriveForUpgrade"
       Directory="INSTALLFOLDER"
-      ExeCommand="&quot;[System64Folder]WindowsPowerShell\v1.0\powershell.exe&quot; -NoP -NonI -WindowStyle Hidden -Command &quot;$p=(pwd).Path+'\resodrive.exe';gps resodrive -ea 0|? Path -eq $p|kill -Force -ea Stop&quot;"
+      ExeCommand="&quot;[System64Folder]WindowsPowerShell\v1.0\powershell.exe&quot; -NoP -NonI -WindowStyle Hidden -Command &quot;$p=(pwd).Path+'\resodrive.exe';gps resodrive -ea 0|? Path -eq $p|%{kill $_ -Force -ea Stop;$_.WaitForExit()};exit 0&quot;"
       Execute="immediate"
       Return="check"
       Impersonate="no"

src/ResoDrive.App/Infrastructure/ApplicationUpdateHandoff.cs

@@ -234,6 +234,11 @@ await runtime.WaitForParentExitAsync(request.ParentProcessId, cancellationToken)
                     cancellationToken)
                 .ConfigureAwait(false);
             (status, message) = ClassifyInstallerExitCode(installerExitCode.Value);
+            if (status == "failed")
+            {
+                message += " See the installer log at " +
+                    Path.ChangeExtension(request.InstallerPath, ".msi.log") + ".";
+            }
         }
         catch (Win32Exception exception) when (exception.NativeErrorCode == ErrorCancelled)
         {

tests/ResoDrive.App.Tests/InstallerPackageTests.cs

@@ -0,0 +1,40 @@
+using System.Xml.Linq;
+
+namespace ResoDrive.App.Tests;
+
+public sealed class InstallerPackageTests
+{
+    private static readonly XNamespace Wix = "http://wixtoolset.org/schemas/v4/wxs";
+
+    [Fact]
+    public void UpgradePreparationIsBestEffortAndRunsWithoutPowerShell()
+    {
+        var action = LoadAction("PrepareInstalledResoDriveForUpgrade");
+
+        Assert.Equal("ResoDriveExecutableFile", (string?)action.Attribute("FileRef"));
+        Assert.Equal("--prepare-update", (string?)action.Attribute("ExeCommand"));
+        Assert.Equal("ignore", (string?)action.Attribute("Return"));
+        Assert.Equal("yes", (string?)action.Attribute("Impersonate"));
+    }
+
+    [Fact]
+    public void UpgradeStopFallbackIsHiddenPathScopedAndWaitsForExit()
+    {
+        var action = LoadAction("StopResoDriveForUpgrade");
+        var command = Assert.IsType<XAttribute>(action.Attribute("ExeCommand")).Value;
+
+        Assert.Equal("check", (string?)action.Attribute("Return"));
+        Assert.Equal("no", (string?)action.Attribute("Impersonate"));
+        Assert.Contains("-WindowStyle Hidden", command, StringComparison.Ordinal);
+        Assert.Contains("Path -eq $p", command, StringComparison.Ordinal);
+        Assert.Contains("WaitForExit()", command, StringComparison.Ordinal);
+        Assert.Contains(";exit 0", command, StringComparison.Ordinal);
+    }
+
+    private static XElement LoadAction(string id)
+    {
+        var document = XDocument.Load(Path.Combine(AppContext.BaseDirectory, "Fixtures", "Package.wxs"));
+        return Assert.Single(document.Descendants(Wix + "CustomAction"), action =>
+            (string?)action.Attribute("Id") == id);
+    }
+}

tests/ResoDrive.App.Tests/ResoDrive.App.Tests.csproj

@@ -28,5 +28,6 @@
     <Content Include="..\..\src\ResoDrive.App\SyncEditorWindow.xaml" Link="Fixtures\SyncEditorWindow.xaml" CopyToOutputDirectory="PreserveNewest" />
     <Content Include="..\..\src\ResoDrive.App\MessageDialog.xaml" Link="Fixtures\MessageDialog.xaml" CopyToOutputDirectory="PreserveNewest" />
     <Content Include="..\..\src\ResoDrive.App\MainWindow.xaml.cs" Link="Fixtures\MainWindow.xaml.cs" CopyToOutputDirectory="PreserveNewest" />
+    <Content Include="..\..\installer\Package.wxs" Link="Fixtures\Package.wxs" CopyToOutputDirectory="PreserveNewest" />
   </ItemGroup>
 </Project>