Skip to content

docs(QTable): add docs - #304

Draft
SeregaBB wants to merge 12 commits into
mainfrom
q-table-docs
Draft

docs(QTable): add docs#304
SeregaBB wants to merge 12 commits into
mainfrom
q-table-docs

Conversation

@SeregaBB

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlify Bot commented Jun 10, 2022

Copy link
Copy Markdown

Deploy Preview for qui-docs failed.

Name Link
🔨 Latest commit 98634cb
🔍 Latest deploy log https://app.netlify.com/sites/qui-docs/deploys/6345939b29f3cc0008c4eefe

@netlify

netlify Bot commented Jun 10, 2022

Copy link
Copy Markdown

Deploy Preview for qui-max ready!

Name Link
🔨 Latest commit 98634cb
🔍 Latest deploy log https://app.netlify.com/sites/qui-max/deploys/6345939b5f184e00093c20ee
😎 Deploy Preview https://deploy-preview-304--qui-max.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SeregaBB
SeregaBB marked this pull request as ready for review June 10, 2022 11:04
@SeregaBB
SeregaBB requested a review from ViZhe June 10, 2022 11:05
# Conflicts:
#	vuepress-docs/docs/.vuepress/config.ts
Comment thread vuepress-docs/docs/components/QTable.md Outdated
@SeregaBB
SeregaBB requested a review from ViZhe June 14, 2022 07:44
v-model:groups-of-columns="groupsOfColumns"
:rows="rows"
:custom-row-class="customRowClass"
></q-table>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в таком представлении, когда Vue встраивается на страницу, а не собирается билдерами, сокращённая запись не работает

return '--row-custom-border-color: var(--color-secondary-orange)';
}
if (rowIndex === 2) {
return '--row-custom-border-color: #f2d22b';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а такой переменной цвета нету ну или похожей?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--color-secondary-yellow

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже нет какой-то специфичной цели отказаться от hex в пользу css переменных в рамках примера, в целом он заимствован из существующей story
а так же если все примеры будут содержать только css переменные может казаться словно других вариантов использования нет, а они есть

{
key: 'one',
draggable: true,
color: '#de4b7a',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно вот так получить доступ к css-переменным)

const styles = getComputedStyle(document.documentElement);
const colorValue = styles.getPropertyValue('--color-primary');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

набор несёт демонстративную цель, тут нет цели получать какой-то конкретный цвет описывая дополнительную логику, а просто показывается что существует такое свойство в которое можно прокинуть hex и получить результат

@ViZhe
ViZhe marked this pull request as draft June 24, 2022 08:20
@cheesytim cheesytim assigned cheesytim and unassigned SeregaBB Sep 20, 2022
@cheesytim cheesytim added the documentation Improvements or additions to documentation label Sep 20, 2022
@netlify

netlify Bot commented Oct 7, 2022

Copy link
Copy Markdown

Deploy Preview for relaxed-kringle-e3b4d3 ready!

Name Link
🔨 Latest commit 98634cb
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-kringle-e3b4d3/deploys/6345939bc15f96000abe4289
😎 Deploy Preview https://deploy-preview-304--relaxed-kringle-e3b4d3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants