Skip to content

[BUG] Outdated-snapshot-reporter fails with custom snapshot ids #341

Description

@LauriNieminen

Describe the bug

Outdated-snapshot-reporter assumes that all snapshot files end with -snap.png. Files that end differently are not reported nor removed when obsolete.

Provide step-by-step guide on how to reproduce the bug

Use a customSnapshotIdentifier that does not end with -snap.png with outdated-snapshot-reporter enabled.
Existing snapshot files will be ignored by the reporter.

expect(image).toMatchImageSnapshot({
    customSnapshotIdentifier: customFilename,
  })
{
(...)
reporters: [
    'default',
    'jest-image-snapshot/src/outdated-snapshot-reporter.js',
    ['jest-junit', { outputDirectory: './build/test-reports/jest' }],
    'jest-stare',
  ],
}

Expected behavior

Outdated-snapshot-reporter does not make assumptions about snapshot identifiers or exposes the suffix as a configurable parameter. Bare minimum would be to document the assumption extremely clearly.

System information

  • Version of jest-image-snapshot: 6.1.0
  • Node version: 18.14.2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions